Bug 183939

Summary: dump-class-layout is just wrong
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: Tools / TestsAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, jfbastien, joepeck, lforschler, simon.fraser, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183311    
Bug Blocks:    
Attachments:
Description Flags
patch none

JF Bastien
Reported 2018-03-23 09:24:58 PDT
Looks like r229291 contained a half-renamed variable in it, so it just doesn't work.
Attachments
patch (2.78 KB, patch)
2018-03-23 09:26 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2018-03-23 09:26:34 PDT
Created attachment 336379 [details] patch
Yusuke Suzuki
Comment 2 2018-03-23 09:41:24 PDT
Comment on attachment 336379 [details] patch r=me
WebKit Commit Bot
Comment 3 2018-03-23 10:07:51 PDT
Comment on attachment 336379 [details] patch Clearing flags on attachment: 336379 Committed r229900: <https://trac.webkit.org/changeset/229900>
WebKit Commit Bot
Comment 4 2018-03-23 10:07:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-03-23 10:08:16 PDT
<rdar://problem/38797356>
Simon Fraser (smfr)
Comment 6 2018-03-23 12:09:16 PDT
Dan was looking at adding tests for this script.
Joseph Pecoraro
Comment 7 2018-03-26 13:19:41 PDT
The title of this bug is misleading. It seems to indicate that the script is wrong, but in reality it just saying that there was a runtime error.
Note You need to log in before you can comment on or make changes to this bug.