Bug 183935

Summary: [Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions
Product: WebKit Reporter: Antoine Quint <graouts>
Component: AnimationsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews205 for win-future none

Antoine Quint
Reported 2018-03-23 08:17:16 PDT
[Web Animations] Correctly handle timing functions specified by CSS Animations and CSS Transitions
Attachments
Patch (25.03 KB, patch)
2018-03-23 08:26 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (24.50 KB, patch)
2018-03-23 08:32 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.20 MB, application/zip)
2018-03-23 16:21 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2018-03-23 08:26:07 PDT
Created attachment 336373 [details] Patch
Antoine Quint
Comment 2 2018-03-23 08:32:47 PDT
Created attachment 336374 [details] Patch
EWS Watchlist
Comment 3 2018-03-23 16:21:04 PDT
Comment on attachment 336374 [details] Patch Attachment 336374 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7080168 New failing tests: imported/mozilla/css-animations/test_animation-computed-timing.html imported/mozilla/css-transitions/test_keyframeeffect-getkeyframes.html
EWS Watchlist
Comment 4 2018-03-23 16:21:15 PDT
Created attachment 336438 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Dean Jackson
Comment 5 2018-03-26 10:58:31 PDT
Comment on attachment 336374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336374&action=review > Source/WebCore/animation/KeyframeEffectReadOnly.cpp:529 > + // For CSS transitions, there are only two keyframes and the second keyframe should always report "linear". In practice, this value > + // has no bearing since, as the last keyframe, its value will never be used. > + computedKeyframe.easing = is<CSSTransition>(animation()) && i == 1 ? "linear" : timingFunctionForKeyframeAtIndex(0)->cssText(); I know this doesn't matter in this case, but I believe "ease" should be the default.
Antoine Quint
Comment 6 2018-03-26 12:08:08 PDT
Committed r229981: <https://trac.webkit.org/changeset/229981>
Radar WebKit Bug Importer
Comment 7 2018-03-26 12:10:18 PDT
<rdar://problem/38876222>
Note You need to log in before you can comment on or make changes to this bug.