Bug 183930

Summary: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tim Horton
Reported 2018-03-22 22:45:51 PDT
Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
Attachments
Patch (12.65 KB, patch)
2018-03-22 22:48 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-22 22:46:23 PDT
<rdar://problem/38782249>
Tim Horton
Comment 2 2018-03-22 22:48:05 PDT
Created attachment 336356 [details] Patch
mitz
Comment 3 2018-03-22 23:15:59 PDT
Comment on attachment 336356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910 > + shellScript = "set -e\n\nif [[ -f \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n ln -s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi"; Oops!
Tim Horton
Comment 4 2018-03-22 23:27:15 PDT
Comment on attachment 336356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review >> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910 >> + shellScript = "set -e\n\nif [[ -f \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n ln -s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi"; > > Oops! Indeed!
WebKit Commit Bot
Comment 5 2018-03-22 23:53:31 PDT
Comment on attachment 336356 [details] Patch Clearing flags on attachment: 336356 Committed r229883: <https://trac.webkit.org/changeset/229883>
WebKit Commit Bot
Comment 6 2018-03-22 23:53:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.