Summary: | Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bdakin, commit-queue, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Tim Horton
2018-03-22 22:45:51 PDT
Created attachment 336356 [details]
Patch
Comment on attachment 336356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910 > + shellScript = "set -e\n\nif [[ -f \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n ln -s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi"; Oops! Comment on attachment 336356 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review >> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910 >> + shellScript = "set -e\n\nif [[ -f \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n ln -s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi"; > > Oops! Indeed! Comment on attachment 336356 [details] Patch Clearing flags on attachment: 336356 Committed r229883: <https://trac.webkit.org/changeset/229883> All reviewed patches have been landed. Closing bug. |