Bug 183930 - Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
Summary: Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-22 22:45 PDT by Tim Horton
Modified: 2018-03-22 23:53 PDT (History)
9 users (show)

See Also:


Attachments
Patch (12.65 KB, patch)
2018-03-22 22:48 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-03-22 22:45:51 PDT
Adopt WK_ALTERNATE_FRAMEWORKS_DIR in WebCore
Comment 1 Radar WebKit Bug Importer 2018-03-22 22:46:23 PDT
<rdar://problem/38782249>
Comment 2 Tim Horton 2018-03-22 22:48:05 PDT
Created attachment 336356 [details]
Patch
Comment 3 mitz 2018-03-22 23:15:59 PDT
Comment on attachment 336356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910
> +			shellScript = "set -e\n\nif [[ -f \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n    ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n    ln -s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi";

Oops!
Comment 4 Tim Horton 2018-03-22 23:27:15 PDT
Comment on attachment 336356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336356&action=review

>> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:9910
>> +			shellScript = "set -e\n\nif [[ -f \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" ]]; then\n    ln -s -f -h \"${BUILT_PRODUCTS_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nelse\n    ln -s -f -h \"${SDK_DIR}${WK_ALTERNATE_WEBKIT_SDK_PATH}/usr/local/lib/libWTF.a\" \"${BUILT_PRODUCTS_DIR}/DerivedSources/JavaScriptCore/libWTF.a\"\nfi";
> 
> Oops!

Indeed!
Comment 5 WebKit Commit Bot 2018-03-22 23:53:31 PDT
Comment on attachment 336356 [details]
Patch

Clearing flags on attachment: 336356

Committed r229883: <https://trac.webkit.org/changeset/229883>
Comment 6 WebKit Commit Bot 2018-03-22 23:53:33 PDT
All reviewed patches have been landed.  Closing bug.