Summary: | Use the same SWServer for all ephemeral sessions | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | Service Workers | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, commit-queue, rniwa, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 186205 | ||||||
Attachments: |
|
Description
Chris Dumez
2018-03-22 15:52:19 PDT
Created attachment 336319 [details]
Patch
Comment on attachment 336319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336319&action=review Not going to r-, but I do have one nit > Source/WebKit/StorageProcess/StorageProcess.cpp:438 > + // Use the same SWServer for all ephemeral sessions. > + if (sessionID.isEphemeral()) > + sessionID = PAL::SessionID::legacyPrivateSessionID(); We eventually want legacyPrivateSessionID() to go away. So it would be nicer if we had some sort of shared "global ephemeral SWServer session ID" But we can also do that later when we get rid of the legacy one. Comment on attachment 336319 [details] Patch Clearing flags on attachment: 336319 Committed r229872: <https://trac.webkit.org/changeset/229872> All reviewed patches have been landed. Closing bug. |