Bug 183894

Summary:

appendQuotedJSONString stops on arithmetic overflow instead of propagating it upwards

Product:

WebKit

Reporter:

Robin Morisset <rmorisset>

Component:

JavaScriptCore

Assignee:

Robin Morisset <rmorisset>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, sevendays37, sunlili, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=184883

Attachments:

Description	Flags
testcase	none
Patch	none
Patch	none

Robin Morisset

Reported 2018-03-22 03:52:12 PDT

Created attachment 336270 [details] testcase This makes JSON.stringify on enormous strings crash instead of cleanly throwing an error. I am planning to fix it by making appendQuotedJSONString return a bool instead of void, with true meaning it succeeded, and false meaning the string turned out to be too big. rdar://problem/37005882

Attachments
testcase (70 bytes, application/x-javascript) 2018-03-22 03:52 PDT, Robin Morisset	no flags	Details
Patch (5.99 KB, patch) 2018-03-23 05:13 PDT, Robin Morisset	no flags	Details Formatted Diff Diff
Patch (5.96 KB, patch) 2018-03-27 08:57 PDT, Robin Morisset	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.