| Summary: | Adopt USE(OPENGL[_ES]) in more places | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | bdakin, benjamin, cdumez, cmarcelo, commit-queue, dbates, dino, ews-watchlist, graouts, jonlee, kondapallykalyan, mitz, mmaxfield, noam, sam, simon.fraser | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Tim Horton
2018-03-21 17:40:34 PDT
Created attachment 336247 [details]
Patch
Created attachment 336248 [details]
Patch
Created attachment 336249 [details]
Patch
Created attachment 336251 [details]
Patch
Comment on attachment 336251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336251&action=review > Source/WebCore/ChangeLog:8 > + Adopt USE(OPENGL[_ES]) in more places > + https://bugs.webkit.org/show_bug.cgi?id=183882 > + <rdar://problem/37912195> > + > + Reviewed by NOBODY (OOPS!). > + This could use a terse why, even if that is just that being more specific makes things clearer. > Source/WebCore/platform/graphics/cocoa/WebGLLayer.mm:67 > +#if USE(OPENGL) > // On Mac, we need to flip the layer to take into account This comment feels a bit wrong now. Created attachment 336262 [details]
Patch
Comment on attachment 336262 [details] Patch Clearing flags on attachment: 336262 Committed r229858: <https://trac.webkit.org/changeset/229858> All reviewed patches have been landed. Closing bug. |