Bug 183859

Summary: Clean up platform VideoFullscreenLayerManager
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Eric Carlson
Reported 2018-03-21 10:33:49 PDT
Every macOS/iOS MediaPlayerPrivate contains identical code for handling fullscreen. Make VideoFullscreenLayerManager an abstract class, add an ObjC version, and put the shared code there.
Attachments
Patch (59.06 KB, patch)
2018-03-21 13:49 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-21 11:19:47 PDT
<rdar://problem/38715419>
Eric Carlson
Comment 2 2018-03-21 13:49:15 PDT
Created attachment 336230 [details] Patch
WebKit Commit Bot
Comment 3 2018-03-21 14:14:03 PDT
Comment on attachment 336230 [details] Patch Clearing flags on attachment: 336230 Committed r229824: <https://trac.webkit.org/changeset/229824>
WebKit Commit Bot
Comment 4 2018-03-21 14:14:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.