Summary: | Use CodeBlock::instructions()[] and CodeBlock::bytecodeOffset() instead of doing own pointer math. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mark Lam
2018-03-21 10:05:43 PDT
Created attachment 336203 [details]
proposed patch.
Attachment 336203 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:199: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4]
Total errors found: 1 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 336203 [details]
proposed patch.
r=me
Comment on attachment 336203 [details]
proposed patch.
Will fix issues.
Created attachment 336206 [details]
proposed patch.
Created attachment 336208 [details]
proposed patch.
Attachment 336208 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:199: Comma should be at the beginning of the line in a member initialization list. [whitespace/init] [4]
Total errors found: 1 in 18 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 336208 [details]
proposed patch.
r=me
Thanks for the review. Landed in r229815: <http://trac.webkit.org/r229815>. |