Bug 183808

Summary: Update the install name for JavaScriptCore when built with WK_ALTERNATE_FRAMEWORKS_DIR
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, saam, sam
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-03-20 22:45:22 PDT
Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR
Attachments
Patch (1.74 KB, patch)
2018-03-20 22:45 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (1.74 KB, patch)
2018-03-20 22:49 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-03-20 22:45:35 PDT
Created attachment 336179 [details] Patch
Tim Horton
Comment 2 2018-03-20 22:45:51 PDT
<rdar://problem/38692079>
mitz
Comment 3 2018-03-20 22:48:45 PDT
Comment on attachment 336179 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336179&action=review > Source/JavaScriptCore/ChangeLog:3 > + Update the DYLD install name for frameworks built with WK_ALTERNATE_FRAMEWORKS_DIR s/DYLD //. Also, you say “frameworks” but only change one framework. Are you going to use this bug for more patches?
Tim Horton
Comment 4 2018-03-20 22:49:54 PDT
Created attachment 336180 [details] Patch
WebKit Commit Bot
Comment 5 2018-03-20 23:26:32 PDT
Comment on attachment 336180 [details] Patch Clearing flags on attachment: 336180 Committed r229789: <https://trac.webkit.org/changeset/229789>
WebKit Commit Bot
Comment 6 2018-03-20 23:26:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.