Bug 183804

Summary: Don't use the presence of a textSelectionAssistant as a proxy for if we are in content editable.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
none
Patch none

Megan Gardner
Reported 2018-03-20 19:33:42 PDT
Don't use the presence of a textSelectionAssistant as a proxy for if we are in content editable.
Attachments
Patch (11.31 KB, patch)
2018-03-20 19:38 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.30 MB, application/zip)
2018-03-20 21:13 PDT, EWS Watchlist 		no flags
Details
Patch (11.45 KB, patch)
2018-03-21 13:37 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (11.50 KB, patch)
2018-03-21 15:06 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-03-21 16:35 PDT, EWS Watchlist 		no flags
Details
Patch (12.53 KB, patch)
2018-03-22 20:27 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (12.06 KB, patch)
2018-03-22 20:51 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-03-20 19:38:52 PDT
Created attachment 336171 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-03-20 19:39:52 PDT
<rdar://problem/38691288>
Tim Horton
Comment 3 2018-03-20 19:58:22 PDT
Comment on attachment 336171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336171&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1525 > + // Send and async message to find out. s/and/an/ > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1637 > + // if we're selecting something, don't activate highlight Comments are complete sentences with capitals and punctuation.
EWS Watchlist
Comment 4 2018-03-20 21:13:46 PDT
Comment on attachment 336171 [details] Patch Attachment 336171 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7046334 New failing tests: editing/selection/character-granularity-rect.html fast/events/focusing-element-with-tabindex-by-tap-or-click.html
EWS Watchlist
Comment 5 2018-03-20 21:13:48 PDT
Created attachment 336175 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Megan Gardner
Comment 6 2018-03-21 13:37:26 PDT
Created attachment 336226 [details] Patch
Megan Gardner
Comment 7 2018-03-21 15:06:15 PDT
Created attachment 336239 [details] Patch
EWS Watchlist
Comment 8 2018-03-21 16:35:06 PDT
Comment on attachment 336239 [details] Patch Attachment 336239 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7056931 New failing tests: editing/selection/character-granularity-rect.html
EWS Watchlist
Comment 9 2018-03-21 16:35:08 PDT
Created attachment 336245 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Megan Gardner
Comment 10 2018-03-22 20:27:37 PDT
Created attachment 336349 [details] Patch
Megan Gardner
Comment 11 2018-03-22 20:51:25 PDT
Created attachment 336352 [details] Patch
WebKit Commit Bot
Comment 12 2018-03-23 14:00:07 PDT
Comment on attachment 336352 [details] Patch Clearing flags on attachment: 336352 Committed r229918: <https://trac.webkit.org/changeset/229918>
WebKit Commit Bot
Comment 13 2018-03-23 14:00:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.