Bug 183804 - Don't use the presence of a textSelectionAssistant as a proxy for if we are in content editable.
Summary: Don't use the presence of a textSelectionAssistant as a proxy for if we are i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-03-20 19:33 PDT by Megan Gardner
Modified: 2018-03-23 14:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (11.31 KB, patch)
2018-03-20 19:38 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.30 MB, application/zip)
2018-03-20 21:13 PDT, EWS Watchlist 		no flags Details
Patch (11.45 KB, patch)
2018-03-21 13:37 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (11.50 KB, patch)
2018-03-21 15:06 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.42 MB, application/zip)
2018-03-21 16:35 PDT, EWS Watchlist 		no flags Details
Patch (12.53 KB, patch)
2018-03-22 20:27 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (12.06 KB, patch)
2018-03-22 20:51 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-03-20 19:33:42 PDT 
Don't use the presence of a textSelectionAssistant as a proxy for if we are in content editable.
Comment 1 Megan Gardner 2018-03-20 19:38:52 PDT 
Created attachment 336171 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-03-20 19:39:52 PDT 
<rdar://problem/38691288>
Comment 3 Tim Horton 2018-03-20 19:58:22 PDT 
Comment on attachment 336171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336171&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1525
> +        // Send and async message to find out.

s/and/an/

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1637
> +    // if we're selecting something, don't activate highlight

Comments are complete sentences with capitals and punctuation.
Comment 4 EWS Watchlist 2018-03-20 21:13:46 PDT 
Comment on attachment 336171 [details]
Patch

Attachment 336171 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7046334

New failing tests:
editing/selection/character-granularity-rect.html
fast/events/focusing-element-with-tabindex-by-tap-or-click.html
Comment 5 EWS Watchlist 2018-03-20 21:13:48 PDT 
Created attachment 336175 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 6 Megan Gardner 2018-03-21 13:37:26 PDT 
Created attachment 336226 [details]
Patch
Comment 7 Megan Gardner 2018-03-21 15:06:15 PDT 
Created attachment 336239 [details]
Patch
Comment 8 EWS Watchlist 2018-03-21 16:35:06 PDT 
Comment on attachment 336239 [details]
Patch

Attachment 336239 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7056931

New failing tests:
editing/selection/character-granularity-rect.html
Comment 9 EWS Watchlist 2018-03-21 16:35:08 PDT 
Created attachment 336245 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 10 Megan Gardner 2018-03-22 20:27:37 PDT 
Created attachment 336349 [details]
Patch
Comment 11 Megan Gardner 2018-03-22 20:51:25 PDT 
Created attachment 336352 [details]
Patch
Comment 12 WebKit Commit Bot 2018-03-23 14:00:07 PDT 
Comment on attachment 336352 [details]
Patch

Clearing flags on attachment: 336352

Committed r229918: <https://trac.webkit.org/changeset/229918>
Comment 13 WebKit Commit Bot 2018-03-23 14:00:08 PDT 
All reviewed patches have been landed.  Closing bug.