Bug 183795

Summary:

We need to do proper bookkeeping of exitOK when inserting constants when sinking NewArrayBuffer

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	jfbastien: review+
patch for landing	none

Description Saam Barati 2018-03-20 13:17:21 PDT

...

Comment 1 Saam Barati 2018-03-20 13:18:07 PDT

<rdar://problem/38298694>

Comment 2 Saam Barati 2018-03-20 13:24:30 PDT

Created attachment 336145 [details]
patch

Comment 3 Mark Lam 2018-03-20 13:27:44 PDT

Comment on attachment 336145 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336145&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        We were just assuming that the constans we were inserting were

/constans/constants/

Comment 4 Saam Barati 2018-03-20 13:32:02 PDT

Created attachment 336146 [details]
patch for landing

Comment 5 WebKit Commit Bot 2018-03-20 14:59:38 PDT

Comment on attachment 336146 [details]
patch for landing

Clearing flags on attachment: 336146

Committed r229775: <https://trac.webkit.org/changeset/229775>

Comment 6 WebKit Commit Bot 2018-03-20 14:59:39 PDT

All reviewed patches have been landed.  Closing bug.