Bug 183793

Summary: [JSC] add support for lexing PrivateName productions
Product: WebKit Reporter: Caitlin Potter (:caitp) <caitp>
Component: New BugsAssignee: Caitlin Potter (:caitp) <caitp>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: darin, ews-watchlist, keith_miller, mark.lam, msaboff, rniwa, saam, ticaiolima, xan.lopez, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews107 for mac-sierra-wk2
none
Archive of layout-test-results from ews103 for mac-sierra
none
Patch
none
Archive of layout-test-results from ews102 for mac-sierra
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Archive of layout-test-results from ews115 for mac-sierra
none
Archive of layout-test-results from ews202 for win-future
none
Patch
none
Patch ews-watchlist: commit-queue-

Caitlin Potter (:caitp)
Reported 2018-03-20 13:01:57 PDT
[JSC] add support for lexing PrivateName productions
Attachments
Patch (10.11 KB, patch)
2018-03-20 13:03 PDT, Caitlin Potter (:caitp)
no flags
Patch (11.44 KB, patch)
2018-03-20 13:38 PDT, Caitlin Potter (:caitp)
no flags
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.98 MB, application/zip)
2018-03-20 14:41 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews103 for mac-sierra (2.20 MB, application/zip)
2018-03-20 14:46 PDT, EWS Watchlist
no flags
Patch (13.31 KB, patch)
2018-03-20 14:57 PDT, Caitlin Potter (:caitp)
no flags
Archive of layout-test-results from ews102 for mac-sierra (2.19 MB, application/zip)
2018-03-20 15:52 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.64 MB, application/zip)
2018-03-20 15:59 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.16 MB, application/zip)
2018-03-20 16:19 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews115 for mac-sierra (2.94 MB, application/zip)
2018-03-20 16:33 PDT, EWS Watchlist
no flags
Archive of layout-test-results from ews202 for win-future (12.14 MB, application/zip)
2018-03-20 16:57 PDT, EWS Watchlist
no flags
Patch (13.36 KB, patch)
2018-03-21 05:35 PDT, Caitlin Potter (:caitp)
no flags
Patch (11.65 KB, patch)
2018-03-21 15:44 PDT, Caitlin Potter (:caitp)
ews-watchlist: commit-queue-
Caitlin Potter (:caitp)
Comment 1 2018-03-20 13:03:19 PDT
Caitlin Potter (:caitp)
Comment 2 2018-03-20 13:06:23 PDT
This is related to https://bugs.webkit.org/show_bug.cgi?id=174212, and adds lexer support for the PrivateName production.
Caitlin Potter (:caitp)
Comment 3 2018-03-20 13:38:59 PDT
Created attachment 336147 [details] Patch slightly better error messages in a few places
EWS Watchlist
Comment 4 2018-03-20 14:41:21 PDT
Comment on attachment 336147 [details] Patch Attachment 336147 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7042655 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 5 2018-03-20 14:41:22 PDT
Created attachment 336153 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 6 2018-03-20 14:46:26 PDT
Comment on attachment 336147 [details] Patch Attachment 336147 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7042808 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 7 2018-03-20 14:46:28 PDT
Created attachment 336154 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Caitlin Potter (:caitp)
Comment 8 2018-03-20 14:57:14 PDT
Created attachment 336156 [details] Patch Fix layout test
EWS Watchlist
Comment 9 2018-03-20 15:52:41 PDT
Comment on attachment 336156 [details] Patch Attachment 336156 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7044000 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 10 2018-03-20 15:52:42 PDT
Created attachment 336159 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 11 2018-03-20 15:59:29 PDT
Comment on attachment 336156 [details] Patch Attachment 336156 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7044026 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 12 2018-03-20 15:59:31 PDT
Created attachment 336161 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 13 2018-03-20 16:19:53 PDT
Comment on attachment 336156 [details] Patch Attachment 336156 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7044037 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 14 2018-03-20 16:19:55 PDT
Created attachment 336163 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 15 2018-03-20 16:33:10 PDT
Comment on attachment 336156 [details] Patch Attachment 336156 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7044040 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 16 2018-03-20 16:33:11 PDT
Created attachment 336165 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
EWS Watchlist
Comment 17 2018-03-20 16:56:51 PDT
Comment on attachment 336156 [details] Patch Attachment 336156 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7044420 New failing tests: js/dom/invalid-syntax-for-function.html
EWS Watchlist
Comment 18 2018-03-20 16:57:02 PDT
Created attachment 336166 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Caitlin Potter (:caitp)
Comment 19 2018-03-21 05:35:39 PDT
Created attachment 336186 [details] Patch _actually_ fix the layout test
Caitlin Potter (:caitp)
Comment 20 2018-03-21 15:44:33 PDT
Created attachment 336243 [details] Patch simplify a bit
Caio Lima
Comment 21 2018-03-21 16:11:13 PDT
Comment on attachment 336243 [details] Patch Patch LGTM. I think you could create some tests for cases where parsing fails. I also think it is good to put it behind a feature flag, since the error message can make the user think that we already support private members.
Caitlin Potter (:caitp)
Comment 22 2018-03-21 16:17:21 PDT
(In reply to Caio Lima from comment #21) > Comment on attachment 336243 [details] > Patch > > Patch LGTM. I think you could create some tests for cases where parsing > fails. I also think it is good to put it behind a feature flag, since the > error message can make the user think that we already support private > members. I think we're going to forego landing this until the class fields work is close to landing, unless port owners are ok with bleeding edge having that error message (which I suspect is not hit often in practice)
EWS Watchlist
Comment 23 2018-03-21 17:08:35 PDT
Comment on attachment 336243 [details] Patch Attachment 336243 [details] did not pass jsc-ews (mac): Output: http://webkit-queues.webkit.org/results/7057267 New failing tests: stress/ftl-put-by-id-setter-exception-interesting-live-state.js.ftl-eager
Yusuke Suzuki
Comment 24 2020-06-12 20:30:33 PDT
Comment on attachment 336243 [details] Patch Private name parsing is already landed.
Yusuke Suzuki
Comment 25 2020-06-15 09:47:11 PDT
*** This bug has been marked as a duplicate of bug 206431 ***
Note You need to log in before you can comment on or make changes to this bug.