Bug 183758

Summary: Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, benjamin, cdumez, cmarcelo, dbates, dino, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews122 for ios-simulator-wk2
none
Patch mitz: review+

Tim Horton
Reported 2018-03-19 18:13:38 PDT
Add and adopt WK_PLATFORM_NAME and adjust default feature defines
Attachments
Patch (99.15 KB, patch)
2018-03-19 18:16 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (98.04 KB, patch)
2018-03-19 18:20 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (103.92 KB, patch)
2018-03-19 22:45 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (105.22 KB, patch)
2018-03-20 00:08 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.24 MB, application/zip)
2018-03-20 01:58 PDT, EWS Watchlist 		no flags
Details
Patch (105.64 KB, patch)
2018-03-20 10:53 PDT, Tim Horton 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-03-19 18:16:00 PDT
Created attachment 336089 [details] Patch
Tim Horton
Comment 2 2018-03-19 18:16:34 PDT
<rdar://problem/38017644>
Tim Horton
Comment 3 2018-03-19 18:20:19 PDT
Created attachment 336092 [details] Patch
mitz
Comment 4 2018-03-19 19:14:38 PDT
Comment on attachment 336092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336092&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38 > +WK_PLATFORM_NAME = $(WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)); > +WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES = iphoneminimalsimulator; > +WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO = $(PLATFORM_NAME); Seems like this could go into the Base.xcconfigs.
Tim Horton
Comment 5 2018-03-19 19:59:09 PDT
Whoops, yes, that’s totally where it belongs.
Tim Horton
Comment 6 2018-03-19 22:45:47 PDT
Created attachment 336104 [details] Patch
EWS Watchlist
Comment 7 2018-03-19 22:47:11 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Tim Horton
Comment 8 2018-03-20 00:08:47 PDT
Created attachment 336106 [details] Patch
EWS Watchlist
Comment 9 2018-03-20 01:57:59 PDT
Comment on attachment 336106 [details] Patch Attachment 336106 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7035873 New failing tests: fast/dom/DeviceMotion/create-event.html imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html fast/dom/DeviceMotion/optional-event-properties.html
EWS Watchlist
Comment 10 2018-03-20 01:58:01 PDT
Created attachment 336110 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Tim Horton
Comment 11 2018-03-20 10:53:51 PDT
Created attachment 336133 [details] Patch
mitz
Comment 12 2018-03-20 11:00:28 PDT
Comment on attachment 336133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336133&action=review > Source/WTF/wtf/FeatureDefines.h:236 > +#if ENABLE(MINIMAL_SIMULATOR) > + > +#if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA) > +#define ENABLE_LEGACY_ENCRYPTED_MEDIA 0 > +#endif > + > +#endif /* ENABLE(MINIMAL_SIMULATOR) */ Makes more sense to move this into the #if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA) below.
Tim Horton
Comment 13 2018-03-20 11:18:52 PDT
https://trac.webkit.org/changeset/229768/webkit
Note You need to log in before you can comment on or make changes to this bug.