| Summary: | Add and adopt WK_PLATFORM_NAME and adjust default feature defines | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | aestes, bdakin, benjamin, cdumez, cmarcelo, dbates, dino, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, wenson_hsieh | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Tim Horton
2018-03-19 18:13:38 PDT
Created attachment 336089 [details]
Patch
Created attachment 336092 [details]
Patch
Comment on attachment 336092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336092&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:38 > +WK_PLATFORM_NAME = $(WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR)); > +WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_YES = iphoneminimalsimulator; > +WK_PLATFORM_NAME_USE_ALTERNATE_FRAMEWORKS_DIR_NO = $(PLATFORM_NAME); Seems like this could go into the Base.xcconfigs. Whoops, yes, that’s totally where it belongs. Created attachment 336104 [details]
Patch
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE Created attachment 336106 [details]
Patch
Comment on attachment 336106 [details] Patch Attachment 336106 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7035873 New failing tests: fast/dom/DeviceMotion/create-event.html imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html fast/dom/DeviceMotion/optional-event-properties.html Created attachment 336110 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 336133 [details]
Patch
Comment on attachment 336133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=336133&action=review > Source/WTF/wtf/FeatureDefines.h:236 > +#if ENABLE(MINIMAL_SIMULATOR) > + > +#if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA) > +#define ENABLE_LEGACY_ENCRYPTED_MEDIA 0 > +#endif > + > +#endif /* ENABLE(MINIMAL_SIMULATOR) */ Makes more sense to move this into the #if !defined(ENABLE_LEGACY_ENCRYPTED_MEDIA) below. |