Bug 183751

Summary: AX: embedded attachments do not work correctly with text marker APIs on macOS
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch none

Description Nan Wang 2018-03-19 14:32:27 PDT
AXUnknown is returned in AXAttributedStringForTextMarkerRange and AXUIElementForTextMarker when there's an embedded attachment.

<rdar://problem/37709113>
Comment 1 Nan Wang 2018-03-19 14:56:23 PDT
Created attachment 336076 [details]
patch
Comment 2 chris fleizach 2018-03-19 15:14:25 PDT
Comment on attachment 336076 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336076&action=review

> Source/WebCore/ChangeLog:8
> +        In WebKit1, embeddd attachments are not working well with text marker APIs.

embedded

> Source/WebCore/ChangeLog:10
> +        1. Hittesting on an attachment object.

hit testing
Comment 3 Nan Wang 2018-03-19 15:21:31 PDT
Created attachment 336077 [details]
patch

update
Comment 4 WebKit Commit Bot 2018-03-19 18:08:57 PDT
Comment on attachment 336077 [details]
patch

Clearing flags on attachment: 336077

Committed r229729: <https://trac.webkit.org/changeset/229729>
Comment 5 WebKit Commit Bot 2018-03-19 18:08:58 PDT
All reviewed patches have been landed.  Closing bug.