Bug 183749

Summary: REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: WPE WebKitAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aperez, bugs-noreply, darin, dino, ews-watchlist, graouts, graouts, kondapallykalyan, mcatanzaro, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2018-03-19 13:27:32 PDT
On revision r225340 <https://trac.webkit.org/r225340> ANGLE was updated, but this update didn't took into account the previous changes that r216497 <https://trac.webkit.org/r216497> did over the eglplatform.h file. Without this change, the WPE port is building the ANGLE target using the X11 types, which seems quite wrong. Also this causes the build to fail on systems not having libx11 (like embedded ones).
Attachments
Patch (2.41 KB, patch)
2018-03-19 13:34 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2018-03-19 13:34:28 PDT
Created attachment 336073 [details] Patch
EWS Watchlist
Comment 2 2018-03-19 13:37:11 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Carlos Alberto Lopez Perez
Comment 3 2018-03-19 15:05:23 PDT
Comment on attachment 336073 [details] Patch Clearing flags on attachment: 336073 Committed r229721: <https://trac.webkit.org/changeset/229721>
Carlos Alberto Lopez Perez
Comment 4 2018-03-19 15:05:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.