Bug 183749 - REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE
Summary: REGRESSION(r225340): WPE port should not be getting EGL X11 types on ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-19 13:27 PDT by Carlos Alberto Lopez Perez
Modified: 2018-03-19 15:05 PDT (History)
11 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2018-03-19 13:34 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2018-03-19 13:27:32 PDT 
On revision r225340 <https://trac.webkit.org/r225340> ANGLE was updated, but this update didn't took into account the previous changes that r216497 <https://trac.webkit.org/r216497> did over the eglplatform.h file.

Without this change, the WPE port is building the ANGLE target using the X11 types, which seems quite wrong.
Also this causes the build to fail on systems not having libx11 (like embedded ones).
Comment 1 Carlos Alberto Lopez Perez 2018-03-19 13:34:28 PDT 
Created attachment 336073 [details]
Patch
Comment 2 EWS Watchlist 2018-03-19 13:37:11 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Carlos Alberto Lopez Perez 2018-03-19 15:05:23 PDT 
Comment on attachment 336073 [details]
Patch

Clearing flags on attachment: 336073

Committed r229721: <https://trac.webkit.org/changeset/229721>
Comment 4 Carlos Alberto Lopez Perez 2018-03-19 15:05:27 PDT 
All reviewed patches have been landed.  Closing bug.