Bug 183736

Summary:

Investigate why __cpu_indicator_init is used

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, ews-watchlist, joepeck, keith_miller, mark.lam, mitz, msaboff, saam, thorton, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
WIP	none
Stop using -all_load	none

Yusuke Suzuki

Reported 2018-03-18 22:13:03 PDT

It calls static initializer. If it is possible, dropping it would be nice.

Attachments
WIP (5.98 KB, patch) 2018-03-19 00:10 PDT, mitz	no flags	Details Formatted Diff Diff
WIP (3.03 KB, patch) 2018-03-19 07:26 PDT, mitz	no flags	Details Formatted Diff Diff
Stop using -all_load (7.53 KB, patch) 2018-03-19 17:16 PDT, mitz	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2018-03-18 22:27:01 PDT

This is happening because we’re passing -all_load to the linker when linking JavaScriptCore, which prevents the linker from eliding __cpu_indicator_init even though it’s unused.

mitz

Comment 2 2018-03-18 22:28:56 PDT

We should probably switch to -force_load for whichever libraries we need.

mitz

Comment 3 2018-03-18 22:40:56 PDT

Also, reexporting libobjc is probably a mistake, introduced in <https://trac.webkit.org/r6086>.

mitz

Comment 4 2018-03-18 22:52:30 PDT

The -all_load was added in <https://trac.webkit.org/r111786> to fix the build after <https://trac.webkit.org/r111778>, but really could have just been -force_load WTF (if all supported linkers had that option at the time).

mitz

Comment 5 2018-03-18 23:06:14 PDT

We might not even need to -force_load WTF (which is tricky, because it requires a configuration-dependent path), if -ObjC is sufficient.

mitz

Comment 6 2018-03-19 00:10:08 PDT

Created attachment 336033 [details] WIP

mitz

Comment 7 2018-03-19 07:26:52 PDT

Created attachment 336043 [details] WIP

mitz

Comment 8 2018-03-19 17:16:36 PDT

Created attachment 336085 [details] Stop using -all_load

WebKit Commit Bot

Comment 9 2018-03-19 20:26:20 PDT

Comment on attachment 336085 [details] Stop using -all_load Clearing flags on attachment: 336085 Committed r229738: <https://trac.webkit.org/changeset/229738>

WebKit Commit Bot

Comment 10 2018-03-19 20:26:21 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 11 2018-03-19 20:27:24 PDT

<rdar://problem/38648167>

Darin Adler

Comment 12 2018-03-20 14:49:23 PDT

Is there some alternative to doing force load for the entire WTF library that would be an even better solution long term?

mitz

Comment 13 2018-03-20 14:54:45 PDT

(In reply to Darin Adler from comment #12) > Is there some alternative to doing force load for the entire WTF library > that would be an even better solution long term? Not loading all of WTF can only be an improvement if we believe that WTF includes or might include unused code. However, I don’t think there’s a good way to predict, when building JavaScriptCore, which parts of WTF that aren’t used in JSC are needed by WebCore and WebKit. If we just add those parts to a list in JavaScriptCore, we’ll have an easy way to add to the list (add something if Web* fails to build without it) but no good way to remove from it.

Note You need to log in before you can comment on or make changes to this bug.