Bug 183725

Summary: REGRESSION (r222113): Tests fail in messages_unittest.py
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: ASSIGNED    
Severity: Normal CC: ap, ddkilzer, jfbastien, lforschler, thorton
Priority: P2 Keywords: Regression
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on: 176984    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2018-03-17 14:57:15 PDT
Steps to reproduce: 1. Open a terminal and change directories to the top-level WebKit checkout. 2. Run `python Source/WebKit/Scripts/webkit/messages_unittest.py` Then the unit tests fail: $ python Source/WebKit/Scripts/webkit/messages_unittest.py F.... ====================================================================== FAIL: test_receiver_headers (__main__.HeaderTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 328, in test_receiver_headers _expected_receiver_header_file_name) File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 318, in assertHeaderEqual self.assertGeneratedFileContentsEqual(actual_file_contents, expected_file_name) File "Source/WebKit/Scripts/webkit/messages_unittest.py", line 312, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: '#include <wtf/HashMap.h>' != '#include <wtf/Forward.h>' ---------------------------------------------------------------------- Ran 5 tests in 0.012s FAILED (failures=1)
Attachments
Patch (1.90 KB, patch)
2018-03-17 15:03 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-03-17 15:03:51 PDT
Created attachment 336014 [details] Patch
Daniel Bates
Comment 2 2018-03-17 15:33:42 PDT
The test failures were caused by the patch for bug #176984. We need to make the messages generator smarter in order for the expected results to use the wtf/Forward.h header instead of wtf/Vector.h.
Daniel Bates
Comment 3 2018-03-17 15:35:45 PDT
Committed in <https://trac.webkit.org/changeset/229697>.
Note You need to log in before you can comment on or make changes to this bug.