Bug 183718

Summary: RenderTreeNeedsLayoutChecker fails with absolutely positioned svg and <use>
Product: WebKit Reporter: zalan <zalan>
Component: SVGAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, koivisto, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 183572    
Attachments:
Description Flags
Test reduction
none
Patch
none
Patch
none
Patch none

Description zalan 2018-03-16 20:12:28 PDT 
Created attachment 335992 [details]
Test reduction

ssia.
Comment 1 zalan 2018-03-20 14:32:34 PDT 
Created attachment 336151 [details]
Patch
Comment 2 Antti Koivisto 2018-03-20 14:39:51 PDT 
Comment on attachment 336151 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=336151&action=review

> Source/WebCore/css/StyleResolver.cpp:816
> +    if (svgElement.hasTagName(SVGNames::svgTag) && (!svgElement.parentNode() || svgElement.parentNode()->isSVGElement() || svgElement.correspondingElement()))

The original test is

if (!(element->hasTagName(SVGNames::svgTag) && element->parentNode() && !element->parentNode()->isSVGElement()))

This doesn't seem like the same.
Comment 3 zalan 2018-03-20 15:15:59 PDT 
Created attachment 336158 [details]
Patch
Comment 4 zalan 2018-03-20 15:53:48 PDT 
Created attachment 336160 [details]
Patch
Comment 5 WebKit Commit Bot 2018-03-20 18:31:14 PDT 
Comment on attachment 336160 [details]
Patch

Clearing flags on attachment: 336160

Committed r229782: <https://trac.webkit.org/changeset/229782>
Comment 6 WebKit Commit Bot 2018-03-20 18:31:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-03-20 18:32:27 PDT 
<rdar://problem/38689390>