Bug 183701

Summary: Make run-webkit-app work for non-GUI apps
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ddkilzer, lforschler, mitz, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch
none
Patch lforschler: review+

Daniel Bates
Reported 2018-03-16 10:25:05 PDT
The run-webkit-app is convenient for running a GUI app with a built WebKit. I do not see a need to restrict this functionality to GUI apps. We should also make run-webkit-app work for non-GUI apps.
Attachments
Patch (2.34 KB, patch)
2018-03-16 10:50 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.34 KB, patch)
2018-03-16 11:24 PDT, Daniel Bates 		lforschler: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-03-16 10:50:26 PDT
Created attachment 335951 [details] Patch
Daniel Bates
Comment 2 2018-03-16 11:24:06 PDT
Created attachment 335954 [details] Patch
Daniel Bates
Comment 3 2018-03-19 11:39:45 PDT
Comment on attachment 335954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335954&action=review > Tools/Scripts/webkitdirs.pm:97 > USE_OPEN_COMMAND > + DO_NOT_USE_OPEN_COMMAND I'll sort these before landing.
Daniel Bates
Comment 4 2018-03-19 13:49:17 PDT
Committed r229711: <https://trac.webkit.org/changeset/229711>
Radar WebKit Bug Importer
Comment 5 2018-03-19 13:50:36 PDT
<rdar://problem/38633433>
Note You need to log in before you can comment on or make changes to this bug.