| Summary: | WebKit.RestoreSessionStateContainingScrollRestorationDefault API test is failing with async policy delegates | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 180568 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Chris Dumez
2018-03-15 14:45:59 PDT
Created attachment 335890 [details]
Patch
Created attachment 335910 [details]
Patch
Comment on attachment 335910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335910&action=review > Source/WebCore/loader/cache/CachedRawResource.cpp:161 > + auto responseProcessedHandler = [this, protectedThis = CachedResourceHandle<CachedRawResource>(this), client] { To make MSVC happy, replace "protectedThis = CachedResourceHandle<CachedRawResource>(this)" with "protectedThis = WTFMove(protectedThis)". MSVC thinks "this" refers to the containing lambda sometimes. Created attachment 335939 [details]
Patch
Created attachment 335945 [details]
Patch
Comment on attachment 335945 [details] Patch Clearing flags on attachment: 335945 Committed r229675: <https://trac.webkit.org/changeset/229675> All reviewed patches have been landed. Closing bug. |