Bug 183675

Summary: Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, dino, ews-watchlist, graouts, keith_miller, kondapallykalyan, mark.lam, mitz, msaboff, saam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Tim Horton
Reported 2018-03-15 14:01:36 PDT
Add and adopt WK_ALTERNATE_FRAMEWORKS_DIR in ANGLE
Attachments
Patch (5.29 KB, patch)
2018-03-15 14:03 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (5.29 KB, patch)
2018-03-15 15:06 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-15 14:03:20 PDT
<rdar://problem/38515281>
Tim Horton
Comment 2 2018-03-15 14:03:49 PDT
Created attachment 335879 [details] Patch
EWS Watchlist
Comment 3 2018-03-15 14:07:08 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
mitz
Comment 4 2018-03-15 15:01:22 PDT
Comment on attachment 335879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335879&action=review > Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:76 > +ANGLE_INSTALL_PATH_PREFIX_YES = $(WK_ALTERNATE_FRAMEWORKS_DIR)/; Why the trailing / here? You seem to not need it in all use sites.
Tim Horton
Comment 5 2018-03-15 15:06:31 PDT
Created attachment 335891 [details] Patch
WebKit Commit Bot
Comment 6 2018-03-15 15:43:06 PDT
Comment on attachment 335891 [details] Patch Clearing flags on attachment: 335891 Committed r229646: <https://trac.webkit.org/changeset/229646>
WebKit Commit Bot
Comment 7 2018-03-15 15:43:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.