Bug 183638

Summary: Add support for boolean properties in BuildbotSyncer while submitting build request to Buildbot 0.9 server
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: TablesAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dean_johnson, dewei_zhu, jbedard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch
none
Updated patch none

Aakash Jain
Reported 2018-03-14 10:32:34 PDT
https://bugs.webkit.org/show_bug.cgi?id=182218 added support to submit build request to Buildbot 0.9 server using HTTP POST request. However the parameters which are of Boolean type (indicating by checkbox) are not set. This is because of the difference between Buildbot 0.8 and 0.9. Earlier we were setting these properties as: checkbox: 'test-webkit'. Now it should be set as: 'test-webkit': true buildbot-syncer.js should allow boolean properties as well.
Attachments
Proposed patch (12.74 KB, patch)
2018-03-14 10:37 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Updated patch (12.28 KB, patch)
2018-03-14 12:18 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-03-14 10:37:00 PDT
Created attachment 335780 [details] Proposed patch
dewei_zhu
Comment 2 2018-03-14 11:00:06 PDT
This change looks good to me. The only concern is whether we should keep both test cases for buildbot 0.8 and 0.9.
Aakash Jain
Comment 3 2018-03-14 12:18:31 PDT
Created attachment 335785 [details] Updated patch Updated patch with Ryosuke's in-person feedback incorporated.
WebKit Commit Bot
Comment 4 2018-03-14 20:17:41 PDT
Comment on attachment 335785 [details] Updated patch Clearing flags on attachment: 335785 Committed r229618: <https://trac.webkit.org/changeset/229618>
WebKit Commit Bot
Comment 5 2018-03-14 20:17:43 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-03-14 20:18:20 PDT
<rdar://problem/38486015>
Note You need to log in before you can comment on or make changes to this bug.