Bug 183614

Summary:

WebCrypto deriveBits should copy its CryptoAlgorithmParameters when hopping to another thread

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

ews-watchlist, jiewen_tan, rniwa

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=183602

Attachments:

Description	Flags
Patch	none
Patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Archive of layout-test-results from ews115 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none

youenn fablet

Reported 2018-03-13 14:11:45 PDT

WebCrypto deriveBits should copy its CryptoAlgorithmParameters when hopping to another thread

Attachments
Patch (18.65 KB, patch) 2018-03-13 14:15 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Patch (19.43 KB, patch) 2018-03-15 16:11 PDT, youenn fablet	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.43 MB, application/zip) 2018-03-15 17:29 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.59 MB, application/zip) 2018-03-15 17:44 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.16 MB, application/zip) 2018-03-15 17:59 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.52 MB, application/zip) 2018-03-15 18:03 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2018-03-13 14:15:02 PDT

Created attachment 335730 [details] Patch

youenn fablet

Comment 2 2018-03-15 16:11:23 PDT

Created attachment 335903 [details] Patch

EWS Watchlist

Comment 3 2018-03-15 17:29:43 PDT

Comment on attachment 335903 [details] Patch Attachment 335903 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6973139 New failing tests: crypto/workers/subtle/pbkdf2-import-key-derive-hmac-key.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html crypto/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html crypto/workers/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html crypto/subtle/pbkdf2-import-key-derive-hmac-key.html

EWS Watchlist

Comment 4 2018-03-15 17:29:44 PDT

Created attachment 335912 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-03-15 17:44:28 PDT

Comment on attachment 335903 [details] Patch Attachment 335903 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6973064 New failing tests: imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html crypto/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html crypto/workers/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html

EWS Watchlist

Comment 6 2018-03-15 17:44:29 PDT

Created attachment 335914 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-03-15 17:59:40 PDT

Comment on attachment 335903 [details] Patch Attachment 335903 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6973342 New failing tests: crypto/workers/subtle/pbkdf2-import-key-derive-hmac-key.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html crypto/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html crypto/workers/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html crypto/subtle/pbkdf2-import-key-derive-hmac-key.html

EWS Watchlist

Comment 8 2018-03-15 17:59:41 PDT

Created attachment 335915 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-03-15 18:03:22 PDT

Comment on attachment 335903 [details] Patch Attachment 335903 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6973542 New failing tests: crypto/workers/subtle/pbkdf2-import-key-derive-hmac-key.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html crypto/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html crypto/workers/subtle/pbkdf2-import-key-derive-bits.html imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html crypto/subtle/pbkdf2-import-key-derive-hmac-key.html

EWS Watchlist

Comment 10 2018-03-15 18:03:24 PDT

Created attachment 335916 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Jiewen Tan

Comment 11 2018-03-15 18:03:56 PDT

Comment on attachment 335903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335903&action=review Please fix all failure tests. > Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:119 > + [baseKey = WTFMove(baseKey), publicKey = makeRef(ecPublicKey), length, unifiedCallback = WTFMove(unifiedCallback), contextIdentifier = context.contextIdentifier()]() mutable { ecPublicKey is just a normal reference. Is it okay to do this? > Source/WebCore/crypto/parameters/CryptoAlgorithmHkdfParams.h:82 > + result.salt = source.salt; We probably want to copy the BufferSource into the Vector directly to avoid a second copy when *Vector() is called. > Source/WebCore/crypto/parameters/CryptoAlgorithmPbkdf2Params.h:75 > + result.m_saltVector = source.m_saltVector; Ditto.

Jiewen Tan

Comment 12 2018-03-15 18:10:57 PDT

Comment on attachment 335903 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335903&action=review > Source/WebCore/crypto/CryptoAlgorithmParameters.h:29 > +#include <wtf/CrossThreadCopier.h> It will be great if this class can work for Objc blocks.

Jiewen Tan

Comment 13 2018-07-13 13:28:52 PDT

*** This bug has been marked as a duplicate of bug 187501 ***

Note You need to log in before you can comment on or make changes to this bug.