Bug 183614 – WebCrypto deriveBits should copy its CryptoAlgorithmParameters when hopping to another thread

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebCore Misc.

[youenn fablet]

WebCrypto deriveBits should copy its CryptoAlgorithmParameters when hopping to another thread

[youenn fablet]

Created attachment 335730 [details]
Patch

[youenn fablet]

Created attachment 335903 [details]
Patch

[EWS Watchlist]

Comment on attachment 335903 [details]
Patch

Attachment 335903 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6973139

New failing tests:
crypto/workers/subtle/pbkdf2-import-key-derive-hmac-key.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html
crypto/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html
crypto/workers/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html
crypto/subtle/pbkdf2-import-key-derive-hmac-key.html

[EWS Watchlist]

Created attachment 335912 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335903 [details]
Patch

Attachment 335903 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6973064

New failing tests:
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html
crypto/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html
crypto/workers/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html

[EWS Watchlist]

Created attachment 335914 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335903 [details]
Patch

Attachment 335903 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6973342

New failing tests:
crypto/workers/subtle/pbkdf2-import-key-derive-hmac-key.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html
crypto/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html
crypto/workers/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html
crypto/subtle/pbkdf2-import-key-derive-hmac-key.html

[EWS Watchlist]

Created attachment 335915 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335903 [details]
Patch

Attachment 335903 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6973542

New failing tests:
crypto/workers/subtle/pbkdf2-import-key-derive-hmac-key.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_long.https.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_long.https.html
crypto/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_short.https.html
crypto/workers/subtle/pbkdf2-import-key-derive-bits.html
imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_short.https.html
crypto/subtle/pbkdf2-import-key-derive-hmac-key.html

[EWS Watchlist]

Created attachment 335916 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Jiewen Tan]

Comment on attachment 335903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335903&action=review

Please fix all failure tests.

> Source/WebCore/crypto/algorithms/CryptoAlgorithmECDH.cpp:119
> +        [baseKey = WTFMove(baseKey), publicKey = makeRef(ecPublicKey), length, unifiedCallback = WTFMove(unifiedCallback), contextIdentifier = context.contextIdentifier()]() mutable {

ecPublicKey is just a normal reference. Is it okay to do this?

> Source/WebCore/crypto/parameters/CryptoAlgorithmHkdfParams.h:82
> +        result.salt = source.salt;

We probably want to copy the BufferSource into the Vector directly to avoid a second copy when *Vector() is called.

> Source/WebCore/crypto/parameters/CryptoAlgorithmPbkdf2Params.h:75
> +        result.m_saltVector = source.m_saltVector;

Ditto.

[Jiewen Tan]

Comment on attachment 335903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335903&action=review

> Source/WebCore/crypto/CryptoAlgorithmParameters.h:29
> +#include <wtf/CrossThreadCopier.h>

It will be great if this class can work for Objc blocks.

[Jiewen Tan]

*** This bug has been marked as a duplicate of bug 187501 ***