Bug 183600

Summary:

Have one service worker process per security origin

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Service Workers

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

beidson, commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

183624, 183626

Bug Blocks:

Attachments:

Description	Flags
WIP patch	ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2	none
WIP patch	none
WIP patch	none
WIP patch	none
WIP patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2018-03-13 10:54:32 PDT

Have one service worker process per security origin for security reasons.

Attachments
WIP patch (69.90 KB, patch) 2018-03-14 12:15 PDT, Chris Dumez	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.67 MB, application/zip) 2018-03-14 13:27 PDT, EWS Watchlist	no flags	Details
WIP patch (59.58 KB, patch) 2018-03-14 16:16 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP patch (59.61 KB, patch) 2018-03-14 16:39 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP patch (59.61 KB, patch) 2018-03-14 16:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
WIP patch (62.74 KB, patch) 2018-03-15 13:34 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (70.25 KB, patch) 2018-03-16 08:55 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (69.89 KB, patch) 2018-03-16 09:09 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (69.83 KB, patch) 2018-03-16 11:57 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (76.04 KB, patch) 2018-03-19 14:01 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (76.06 KB, patch) 2018-03-19 14:30 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-03-13 10:54:48 PDT

<rdar://problem/35280128>

Chris Dumez

Comment 2 2018-03-14 12:15:59 PDT

Created attachment 335784 [details] WIP patch

EWS Watchlist

Comment 3 2018-03-14 12:18:41 PDT

Attachment 335784 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2018-03-14 13:27:49 PDT

Comment on attachment 335784 [details] WIP patch Attachment 335784 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6953741 New failing tests: http/tests/workers/service/postmessage-after-sw-process-crash.https.html

EWS Watchlist

Comment 5 2018-03-14 13:27:51 PDT

Created attachment 335792 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 6 2018-03-14 16:16:26 PDT

Created attachment 335806 [details] WIP patch

EWS Watchlist

Comment 7 2018-03-14 16:17:33 PDT

Attachment 335806 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 8 2018-03-14 16:39:05 PDT

Created attachment 335808 [details] WIP patch

EWS Watchlist

Comment 9 2018-03-14 16:41:57 PDT

Attachment 335808 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 10 2018-03-14 16:52:41 PDT

Created attachment 335810 [details] WIP patch

EWS Watchlist

Comment 11 2018-03-14 16:56:31 PDT

Attachment 335810 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 12 2018-03-15 13:34:28 PDT

Created attachment 335876 [details] WIP patch

EWS Watchlist

Comment 13 2018-03-15 13:35:53 PDT

Attachment 335876 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 14 2018-03-16 08:55:54 PDT

Created attachment 335940 [details] Patch

EWS Watchlist

Comment 15 2018-03-16 08:56:59 PDT

Attachment 335940 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 16 2018-03-16 09:09:14 PDT

Created attachment 335941 [details] Patch

EWS Watchlist

Comment 17 2018-03-16 09:10:14 PDT

Attachment 335941 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 18 2018-03-16 11:57:29 PDT

Created attachment 335958 [details] Patch

EWS Watchlist

Comment 19 2018-03-16 12:00:20 PDT

Attachment 335958 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 20 2018-03-16 15:44:47 PDT

Patch is ready for review.

Brady Eidson

Comment 21 2018-03-19 11:31:47 PDT

Comment on attachment 335958 [details] Patch I think we should be able to API test this?

Chris Dumez

Comment 22 2018-03-19 12:33:33 PDT

(In reply to Brady Eidson from comment #21) > Comment on attachment 335958 [details] > Patch > > I think we should be able to API test this? As discussed offline, you are probably right and I'll look into adding such test shortly.

Chris Dumez

Comment 23 2018-03-19 14:01:30 PDT

Created attachment 336074 [details] Patch

Chris Dumez

Comment 24 2018-03-19 14:02:26 PDT

Comment on attachment 336074 [details] Patch Now with an API test.

EWS Watchlist

Comment 25 2018-03-19 14:03:10 PDT

Attachment 336074 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 26 2018-03-19 14:30:07 PDT

Created attachment 336075 [details] Patch

EWS Watchlist

Comment 27 2018-03-19 14:32:42 PDT

Attachment 336075 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 28 2018-03-19 19:31:52 PDT

Comment on attachment 336075 [details] Patch Clearing flags on attachment: 336075 Committed r229735: <https://trac.webkit.org/changeset/229735>

WebKit Commit Bot

Comment 29 2018-03-19 19:31:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.