| Summary: | Have one service worker process per security origin | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||||||||
| Component: | Service Workers | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||
| Severity: | Normal | CC: | beidson, commit-queue, ews-watchlist, rniwa, webkit-bug-importer, youennf | ||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||
| Bug Depends on: | 183624, 183626 | ||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
Chris Dumez
2018-03-13 10:54:32 PDT
Created attachment 335784 [details]
WIP patch
Attachment 335784 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 335784 [details] WIP patch Attachment 335784 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6953741 New failing tests: http/tests/workers/service/postmessage-after-sw-process-crash.https.html Created attachment 335792 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 335806 [details]
WIP patch
Attachment 335806 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 335808 [details]
WIP patch
Attachment 335808 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 335810 [details]
WIP patch
Attachment 335810 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 335876 [details]
WIP patch
Attachment 335876 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 25 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 335940 [details]
Patch
Attachment 335940 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 335941 [details]
Patch
Attachment 335941 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 335958 [details]
Patch
Attachment 335958 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 27 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Patch is ready for review. Comment on attachment 335958 [details]
Patch
I think we should be able to API test this?
(In reply to Brady Eidson from comment #21) > Comment on attachment 335958 [details] > Patch > > I think we should be able to API test this? As discussed offline, you are probably right and I'll look into adding such test shortly. Created attachment 336074 [details]
Patch
Comment on attachment 336074 [details]
Patch
Now with an API test.
Attachment 336074 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 336075 [details]
Patch
Attachment 336075 [details] did not pass style-queue:
ERROR: Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:54: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 1 in 30 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 336075 [details] Patch Clearing flags on attachment: 336075 Committed r229735: <https://trac.webkit.org/changeset/229735> All reviewed patches have been landed. Closing bug. |