Bug 183590

Summary: [DFG][FTL] Make ArraySlice(0) code tight
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2018-03-12 23:24:47 PDT
[DFG][FTL] Make ArraySlice(0) code tight
Attachments
Patch (3.01 KB, patch)
2018-03-12 23:33 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (15.14 KB, patch)
2018-03-13 03:47 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-03-12 23:33:19 PDT
Created attachment 335683 [details] Patch
EWS Watchlist
Comment 2 2018-03-12 23:35:32 PDT
Attachment 335683 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7632: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Yusuke Suzuki
Comment 3 2018-03-13 03:47:08 PDT
Created attachment 335688 [details] Patch
EWS Watchlist
Comment 4 2018-03-13 03:49:45 PDT
Attachment 335688 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7624: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7635: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7689: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Saam Barati
Comment 5 2018-03-19 22:37:23 PDT
Comment on attachment 335688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335688&action=review > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1079 > + fixEdge<Int32Use>(m_graph.varArgChild(node, 1)); Don’t you want to do this if count >= 2? > Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1080 > + if (node->numChildren() == 4) Ignore above comment (bugzilla on my phone is not allowing me to delete the above comment). I misread the code.
Yusuke Suzuki
Comment 6 2018-03-20 00:12:10 PDT
Comment on attachment 335688 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335688&action=review >> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1080 >> + if (node->numChildren() == 4) > > Ignore above comment (bugzilla on my phone is not allowing me to delete the above comment). I misread the code. OK, thanks!
Yusuke Suzuki
Comment 7 2018-03-20 00:13:01 PDT
Committed r229742: <https://trac.webkit.org/changeset/229742>
Radar WebKit Bug Importer
Comment 8 2018-03-20 00:13:16 PDT
<rdar://problem/38653765>
Note You need to log in before you can comment on or make changes to this bug.