Bug 183588

Summary: fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, commit-queue, rniwa, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 180568    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2018-03-12 20:25:34 PDT
fast/loader/javascript-url-iframe-remove-on-navigate.html is flaky with async policy delegates:
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt
@@ -1,2 +1 @@
-Blocked access to external URL http://does.not.exist/
 PASS - Javascript URL blocked without crashing.
Comment 1 Chris Dumez 2018-03-12 20:27:44 PDT
Also:
--- /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-expected.txt
+++ /Volumes/Data/WebKit/OpenSource/WebKitBuild/Debug/layout-test-results/fast/loader/javascript-url-iframe-remove-on-navigate-actual.txt
@@ -1,2 +1,2 @@
-Blocked access to external URL http://does.not.exist/
+ALERT: FAIL
 PASS - Javascript URL blocked without crashing.
Comment 2 Chris Dumez 2018-03-13 10:00:01 PDT
Created attachment 335701 [details]
Patch
Comment 3 Ryosuke Niwa 2018-03-13 11:06:18 PDT
Comment on attachment 335701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335701&action=review

> LayoutTests/ChangeLog:15
> +        I checked that this test was printing the "FAIL" alert in both Firefox and Chrome before
> +        this change.

So both Chrome & Firefox run javascript protocol async?
Comment 4 WebKit Commit Bot 2018-03-13 11:07:35 PDT
Comment on attachment 335701 [details]
Patch

Clearing flags on attachment: 335701

Committed r229579: <https://trac.webkit.org/changeset/229579>
Comment 5 WebKit Commit Bot 2018-03-13 11:07:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-03-13 11:08:20 PDT
<rdar://problem/38423408>