Bug 183584

Summary:

Ignore some deprecation warnings encountered when compiling with newer versions of ICU

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Text

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, dbates, mitz, mmaxfield, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=183355

Attachments:

Description	Flags
Patch	none

Description BJ Burg 2018-03-12 16:28:22 PDT

Comment 1 BJ Burg 2018-03-12 16:28:42 PDT

<rdar://problem/38395317>

Comment 2 BJ Burg 2018-03-12 16:32:54 PDT

Created attachment 335662 [details]
Patch

Comment 3 BJ Burg 2018-03-12 16:33:36 PDT

Reviewed offline by dbates.

Comment 4 Myles C. Maxfield 2018-03-12 16:37:12 PDT

Comment on attachment 335662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335662&action=review

> Source/WebCore/editing/TextIterator.cpp:2004
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Usually we do this around each individual call.

> Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp:74
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Ditto.

> Source/WebCore/platform/text/TextEncoding.cpp:74
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Ditto.

Comment 5 BJ Burg 2018-03-12 16:46:11 PDT

Committed r229564: <https://trac.webkit.org/changeset/229564>

Comment 6 mitz 2018-03-12 16:54:29 PDT

Please just bug 183355 already.