Bug 183584

Summary: Ignore some deprecation warnings encountered when compiling with newer versions of ICU
Product: WebKit Reporter: Blaze Burg <bburg>
Component: TextAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, dbates, mitz, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=183355
Attachments:
Description Flags
Patch none

Blaze Burg
Reported 2018-03-12 16:28:22 PDT
.
Attachments
Patch (4.21 KB, patch)
2018-03-12 16:32 PDT, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2018-03-12 16:28:42 PDT
<rdar://problem/38395317>
Blaze Burg
Comment 2 2018-03-12 16:32:54 PDT
Created attachment 335662 [details] Patch
Blaze Burg
Comment 3 2018-03-12 16:33:36 PDT
Reviewed offline by dbates.
Myles C. Maxfield
Comment 4 2018-03-12 16:37:12 PDT
Comment on attachment 335662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335662&action=review > Source/WebCore/editing/TextIterator.cpp:2004 > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" Usually we do this around each individual call. > Source/WebCore/platform/graphics/SurrogatePairAwareTextIterator.cpp:74 > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" Ditto. > Source/WebCore/platform/text/TextEncoding.cpp:74 > +#pragma clang diagnostic ignored "-Wdeprecated-declarations" Ditto.
Blaze Burg
Comment 5 2018-03-12 16:46:11 PDT
Committed r229564: <https://trac.webkit.org/changeset/229564>
mitz
Comment 6 2018-03-12 16:54:29 PDT
Please just bug 183355 already.
Note You need to log in before you can comment on or make changes to this bug.