Bug 183535
| Summary: | [WebAuthN] Improve CBOR encoding/decoding | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | alex.gaynor, jiewen_tan, jonathan, jschoi, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 181943 | ||
Jiewen Tan
CBOR encoder needs to deal with bytes directly.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/43357405>
Jiewen Tan
Actually, this bug applies to all different value types the encoder support. Instead of holding the value, the encoder will be more efficient to provide a mode to only hold a reference to the value and then let the caller to guarantee the value is unchanged and alive during the encoding period. Anyway, it will be good to optimize it but not a blocker for the feature.
Jiewen Tan
We should consider adding && getter for CBORValue.