Bug 183524

Summary:

Web Inspector: there should only be one way for async backend commands to send failure

Product:

WebKit

Reporter:

BJ Burg <bburg>

Component:

Web Inspector

Assignee:

BJ Burg <bburg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bburg, commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, keith_miller, lforschler, mark.lam, msaboff, saam, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Description BJ Burg 2018-03-09 14:12:52 PST

Currently code does callback->sendFailure, and some code just sets the ErrorString, which doesn't really do anything. Don't include an ErrorString out-param for async backend commands.

Comment 1 BJ Burg 2018-03-09 15:07:54 PST

Created attachment 335471 [details]
Patch

Comment 2 EWS Watchlist 2018-03-09 15:12:26 PST

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

Comment 3 EWS Watchlist 2018-03-09 15:12:40 PST

Attachment 335471 [details] did not pass style-queue:


ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:567:  out_document is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.cpp:567:  out_idbFactory is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66:  in_securityOrigin is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66:  in_databaseName is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/inspector/agents/InspectorIndexedDBAgent.h:66:  in_objectStoreName is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 5 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Timothy Hatcher 2018-03-09 15:32:38 PST

Comment on attachment 335471 [details]
Patch

Nice!

Comment 5 WebKit Commit Bot 2018-03-09 16:43:09 PST

Comment on attachment 335471 [details]
Patch

Clearing flags on attachment: 335471

Committed r229493: <https://trac.webkit.org/changeset/229493>

Comment 6 WebKit Commit Bot 2018-03-09 16:43:11 PST

All reviewed patches have been landed.  Closing bug.

Comment 7 Radar WebKit Bug Importer 2018-03-12 17:22:39 PDT

<rdar://problem/38397805>