Summary: | [GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, bugs-noreply, ews-watchlist, gustavo, mcatanzaro | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2018-03-09 03:50:11 PST
Created attachment 335416 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 335416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335416&action=review > Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:594 > + * @form: the #WebKitDOMElement to be submitted the #WebKitDOMElement to be submitted, which will always correspond to an HTMLFormElement > Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:385 > + GUniquePtr<char> formID(webkit_dom_element_get_id(formElement)); Oops. I wish it was not transfer full. :( But I guess the ID can change at any time. Committed r229461: <https://trac.webkit.org/changeset/229461> |