Bug 183501

Summary: Unconditionalize more methods in VideoFullscreenInterface (and related classes)
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Description Jer Noble 2018-03-08 23:16:00 PST 
Unconditionalize more methods in VideoFullscreenInterface (and related classes)
Comment 1 Jer Noble 2018-03-08 23:17:42 PST 
Created attachment 335400 [details]
Patch
Comment 2 Jer Noble 2018-03-09 11:44:36 PST 
Created attachment 335442 [details]
Patch
Comment 3 Jer Noble 2018-03-09 11:54:15 PST 
Created attachment 335443 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2018-03-09 11:57:47 PST 
<rdar://problem/38312038>
Comment 5 Eric Carlson 2018-03-09 12:09:39 PST 
Comment on attachment 335443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335443&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154
> +    bool isPlayingVideoInEnhancedFullscreen() const;

Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to something like "isPlayingVideoInPictureInPicture" as long as you are updating?
Comment 6 Jer Noble 2018-03-09 13:03:46 PST 
(In reply to Eric Carlson from comment #5)
> Comment on attachment 335443 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=335443&action=review
> 
> > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154
> > +    bool isPlayingVideoInEnhancedFullscreen() const;
> 
> Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to
> something like "isPlayingVideoInPictureInPicture" as long as you are
> updating?

We'd have to change it everywhere at once, but I could take a stab at it.
Comment 7 Jer Noble 2018-03-09 14:16:15 PST 
Created attachment 335461 [details]
Patch for landing
Comment 8 WebKit Commit Bot 2018-03-09 14:56:56 PST 
Comment on attachment 335461 [details]
Patch for landing

Clearing flags on attachment: 335461

Committed r229485: <https://trac.webkit.org/changeset/229485>
Comment 9 WebKit Commit Bot 2018-03-09 14:56:57 PST 
All reviewed patches have been landed.  Closing bug.
Comment 10 Jer Noble 2018-03-09 17:18:35 PST 
Landed follow-up build fix in http://trac.webkit.org/r229494