Bug 183501

Summary: Unconditionalize more methods in VideoFullscreenInterface (and related classes)
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing none

Jer Noble
Reported 2018-03-08 23:16:00 PST
Unconditionalize more methods in VideoFullscreenInterface (and related classes)
Attachments
Patch (16.47 KB, patch)
2018-03-08 23:17 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (16.47 KB, patch)
2018-03-09 11:44 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (16.52 KB, patch)
2018-03-09 11:54 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (16.56 KB, patch)
2018-03-09 14:16 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-03-08 23:17:42 PST
Created attachment 335400 [details] Patch
Jer Noble
Comment 2 2018-03-09 11:44:36 PST
Created attachment 335442 [details] Patch
Jer Noble
Comment 3 2018-03-09 11:54:15 PST
Created attachment 335443 [details] Patch
Radar WebKit Bug Importer
Comment 4 2018-03-09 11:57:47 PST
<rdar://problem/38312038>
Eric Carlson
Comment 5 2018-03-09 12:09:39 PST
Comment on attachment 335443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335443&action=review > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154 > + bool isPlayingVideoInEnhancedFullscreen() const; Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to something like "isPlayingVideoInPictureInPicture" as long as you are updating?
Jer Noble
Comment 6 2018-03-09 13:03:46 PST
(In reply to Eric Carlson from comment #5) > Comment on attachment 335443 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=335443&action=review > > > Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154 > > + bool isPlayingVideoInEnhancedFullscreen() const; > > Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to > something like "isPlayingVideoInPictureInPicture" as long as you are > updating? We'd have to change it everywhere at once, but I could take a stab at it.
Jer Noble
Comment 7 2018-03-09 14:16:15 PST
Created attachment 335461 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-03-09 14:56:56 PST
Comment on attachment 335461 [details] Patch for landing Clearing flags on attachment: 335461 Committed r229485: <https://trac.webkit.org/changeset/229485>
WebKit Commit Bot
Comment 9 2018-03-09 14:56:57 PST
All reviewed patches have been landed. Closing bug.
Jer Noble
Comment 10 2018-03-09 17:18:35 PST
Landed follow-up build fix in http://trac.webkit.org/r229494
Note You need to log in before you can comment on or make changes to this bug.