Bug 183488

Summary: testmasm crashes in testBranchTruncateDoubleToInt32() on ARM64
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: jlewis3, mark.lam, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for landing none

Description Michael Saboff 2018-03-08 17:21:25 PST
The code was written by adjusting sp down by 8 bytes.  ARM64 hardware asserts that sp is 16 byte align when used as the destination of the load/store.  The fix is to keep the stack aligned.
Comment 1 Michael Saboff 2018-03-08 17:30:08 PST
Created attachment 335371 [details]
Patch for landing
Comment 2 Michael Saboff 2018-03-08 17:46:25 PST
Committed r229446: <https://trac.webkit.org/changeset/229446>
Comment 3 Radar WebKit Bug Importer 2018-03-08 17:47:18 PST
<rdar://problem/38285026>
Comment 4 Ryan Haddad 2018-03-09 10:00:14 PST
Reverted r229446 for reason:

This change relies on changes that have been rolled out.

Committed r229464: <https://trac.webkit.org/changeset/229464>
Comment 5 Matt Lewis 2018-03-09 13:15:34 PST
This looks to have broke The High Sierra LLINT CLoop build when it was re-landed in https://trac.webkit.org/changeset/229476/webkit

https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/4330

https://build.webkit.org/builders/Apple%20High%20Sierra%20LLINT%20CLoop%20%28BuildAndTest%29/builds/4330/steps/compile-webkit/logs/stdio

/Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:45:80: error: use of undeclared identifier 'CallFrame'
/Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:45:116: error: use of undeclared identifier 'CallFrame'
/Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:52:85: error: use of undeclared identifier 'CallerFrameAndPC'
/Volumes/Data/slave/highsierra-cloop-debug/build/Source/JavaScriptCore/runtime/StackAlignment.h:52:122: error: use of undeclared identifier 'CallerFrameAndPC'
Comment 6 Mark Lam 2018-03-09 15:04:14 PST
Michael relanded the patch in r229476: <http://trac.webkit.org/r229476>.
Comment 7 Mark Lam 2018-03-09 15:08:10 PST
Build fix landed in r229486: <http://trac.webkit.org/r229486>.