Bug 183460

Summary: http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ajuma, commit-queue, jlewis3, lforschler, ryanhaddad, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=183902
Bug Depends on:    
Bug Blocks: 180568    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2018-03-08 10:09:01 PST
http/tests/security/frame-loading-via-document-write-async-delegates.html fails with async delegates.
Attachments
Patch (8.55 KB, patch)
2018-03-08 10:16 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2018-03-12 10:03 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.33 KB, patch)
2018-03-12 10:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-03-08 10:16:20 PST
Created attachment 335314 [details] Patch
Ali Juma
Comment 2 2018-03-08 10:19:41 PST
*** Bug 183461 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 3 2018-03-09 10:46:03 PST
Comment on attachment 335314 [details] Patch Clearing flags on attachment: 335314 Committed r229468: <https://trac.webkit.org/changeset/229468>
WebKit Commit Bot
Comment 4 2018-03-09 10:46:05 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-03-09 10:47:18 PST
<rdar://problem/38308346>
Matt Lewis
Comment 6 2018-03-09 17:04:26 PST
This caused the test http/tests/security/frame-loading-via-document-write.html to fail consistently on all platforms: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fframe-loading-via-document-write.html https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229487%20(3367)/results.html diff: --- /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/security/frame-loading-via-document-write-expected.txt +++ /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/http/tests/security/frame-loading-via-document-write-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 1: Not allowed to load local resource: abe.png +CONSOLE MESSAGE: line 55: Not allowed to load local resource: abe.png --------
Chris Dumez
Comment 7 2018-03-09 17:26:30 PST
(In reply to Matt Lewis from comment #6) > This caused the test > http/tests/security/frame-loading-via-document-write.html to fail > consistently on all platforms: > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=http%2Ftests%2Fsecurity%2Fframe-loading-via- > document-write.html > > https://build.webkit.org/results/ > Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r229487%20(3367)/results.html > > diff: > --- > /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/ > http/tests/security/frame-loading-via-document-write-expected.txt > +++ > /Volumes/Data/slave/highsierra-release-tests-wk2/build/layout-test-results/ > http/tests/security/frame-loading-via-document-write-actual.txt > @@ -1,4 +1,4 @@ > -CONSOLE MESSAGE: line 1: Not allowed to load local resource: abe.png > +CONSOLE MESSAGE: line 55: Not allowed to load local resource: abe.png > > > -------- Looks like this merely needs rebaselining. Weird that EWS was green...
Ryan Haddad
Comment 8 2018-03-09 17:28:12 PST
Reverted r229468 for reason: This change caused http/tests/security/frame-loading-via-document-write.html to fail. Committed r229496: <https://trac.webkit.org/changeset/229496>
Chris Dumez
Comment 9 2018-03-12 10:03:04 PDT
Created attachment 335601 [details] Patch
WebKit Commit Bot
Comment 10 2018-03-12 10:04:24 PDT
Comment on attachment 335601 [details] Patch Rejecting attachment 335601 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 335601, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/6916570
Chris Dumez
Comment 11 2018-03-12 10:12:53 PDT
Created attachment 335603 [details] Patch
WebKit Commit Bot
Comment 12 2018-03-12 10:50:58 PDT
Comment on attachment 335603 [details] Patch Clearing flags on attachment: 335603 Committed r229539: <https://trac.webkit.org/changeset/229539>
WebKit Commit Bot
Comment 13 2018-03-12 10:51:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.