Bug 183450

Summary: [Win] Use __debugbreak for WTFBreakpointTrap
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, benjamin, cdumez, cmarcelo, darin, dbates, don.olmstead, ews-watchlist, mark.lam, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2018-03-08 06:24:46 PST
[Win] Use __debugbreak for WTFBreakpointTrap
Comment 1 Yusuke Suzuki 2018-03-08 06:25:51 PST
Created attachment 335296 [details]
Patch
Comment 2 Mark Lam 2018-03-08 07:24:54 PST
Comment on attachment 335296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review

r=me

> Source/WTF/wtf/Assertions.h:212
> +#else
>  #if ASAN_ENABLED

Change this into an "#elif ASAN_ENABLED" because these cases should all be mutually exclusive.

> Source/WTF/wtf/Assertions.h:223
> +#endif // COMPILER(MSVC)

Remove this.
Comment 3 Yusuke Suzuki 2018-03-08 07:43:35 PST
Comment on attachment 335296 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review

Thank you!

>> Source/WTF/wtf/Assertions.h:212
>>  #if ASAN_ENABLED
> 
> Change this into an "#elif ASAN_ENABLED" because these cases should all be mutually exclusive.

OK, changed.

>> Source/WTF/wtf/Assertions.h:223
>> +#endif // COMPILER(MSVC)
> 
> Remove this.

Fixed.
Comment 4 Yusuke Suzuki 2018-03-08 07:47:31 PST
Committed r229409: <https://trac.webkit.org/changeset/229409>
Comment 5 Radar WebKit Bug Importer 2018-03-08 07:48:34 PST
<rdar://problem/38262145>