Bug 183449

Summary: [JSC][WebCore] Extend jsDynamicCast for WebCore types in WebCore and remove jsDynamicDowncast
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: WebCore Misc.Assignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 183429    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch mark.lam: review+

Yusuke Suzuki
Reported 2018-03-08 06:12:13 PST
Now, jsDynamicCast has the same / similar mechanism to WebCore::jsDynamicDowncast to inject efficient casting. So, let's remove jsDynamicDowncast. And inject WebCore specializations into JSC::jsDynamicCast in WebCore side.
Attachments
Patch (209.35 KB, patch)
2018-03-08 09:11 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (209.35 KB, patch)
2018-03-08 09:47 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-03-08 09:11:03 PST
Created attachment 335301 [details] Patch
Yusuke Suzuki
Comment 2 2018-03-08 09:47:07 PST
Created attachment 335310 [details] Patch
Mark Lam
Comment 3 2018-03-08 10:17:02 PST
Comment on attachment 335310 [details] Patch r=me
Yusuke Suzuki
Comment 4 2018-03-08 10:38:16 PST
Committed r229416: <https://trac.webkit.org/changeset/229416>
Radar WebKit Bug Importer
Comment 5 2018-03-08 10:39:30 PST
<rdar://problem/38268343>
Yusuke Suzuki
Comment 6 2018-04-01 12:26:12 PDT
*** Bug 172685 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.