Bug 183430

Summary:

Stop using SDK conditionals to control feature definitions

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aestes, bdakin, commit-queue, eric.carlson, ews-watchlist, keith_miller, mark.lam, mitz, msaboff, rniwa, saam, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews113 for mac-sierra	none
Patch	none
Patch	none

Tim Horton

Reported 2018-03-07 23:16:45 PST

Stop using SDK conditionals to control feature definitions

Attachments
Patch (179.08 KB, patch) 2018-03-07 23:19 PST, Tim Horton	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.25 MB, application/zip) 2018-03-08 00:47 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.68 MB, application/zip) 2018-03-08 00:59 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews113 for mac-sierra (2.94 MB, application/zip) 2018-03-08 01:16 PST, EWS Watchlist	no flags	Details
Patch (179.34 KB, patch) 2018-03-08 01:32 PST, Tim Horton	no flags	Details Formatted Diff Diff
Patch (180.87 KB, patch) 2018-03-12 17:37 PDT, Tim Horton	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2018-03-07 23:19:56 PST

Created attachment 335267 [details] Patch

Tim Horton

Comment 2 2018-03-07 23:21:19 PST

<rdar://problem/38251619>

EWS Watchlist

Comment 3 2018-03-08 00:47:14 PST Comment hidden (obsolete)

Comment on attachment 335267 [details] Patch Attachment 335267 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/6851742 New failing tests: imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html

EWS Watchlist

Comment 4 2018-03-08 00:47:15 PST Comment hidden (obsolete)

Created attachment 335274 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-03-08 00:59:26 PST Comment hidden (obsolete)

Comment on attachment 335267 [details] Patch Attachment 335267 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/6851941 New failing tests: imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html gamepad/gamepad-event.html gamepad/gamepad-api.html gamepad/gamepad-polling-access.html

EWS Watchlist

Comment 6 2018-03-08 00:59:28 PST Comment hidden (obsolete)

Created attachment 335275 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-03-08 01:16:41 PST Comment hidden (obsolete)

Comment on attachment 335267 [details] Patch Attachment 335267 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/6851951 New failing tests: imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html

EWS Watchlist

Comment 8 2018-03-08 01:16:42 PST Comment hidden (obsolete)

Created attachment 335278 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6

Tim Horton

Comment 9 2018-03-08 01:32:09 PST

Created attachment 335280 [details] Patch

mitz

Comment 10 2018-03-12 12:38:52 PDT

Comment on attachment 335280 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335280&action=review > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:304 > +ENABLE_VIDEO_PRESENTATION_MODE = $(ENABLE_VIDEO_PRESENTATION_MODE_$(PLATFORM_NAME)); > +ENABLE_VIDEO_PRESENTATION_MODE_iphoneos = ENABLE_VIDEO_PRESENTATION_MODE; > +ENABLE_VIDEO_PRESENTATION_MODE_iphonesimulator = ENABLE_VIDEO_PRESENTATION_MODE; This changes something for non-iOS Cocoa Touch platforms, right? > Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:331 > +ENABLE_WEB_RTC_iphoneos[arch=arm64*] = ENABLE_WEB_RTC; > +ENABLE_WEB_RTC_iphonesimulator[arch=x86_64] = ENABLE_WEB_RTC; Not sure these architecture conditionals are still necessary.

Tim Horton

Comment 11 2018-03-12 17:37:16 PDT

Created attachment 335666 [details] Patch

WebKit Commit Bot

Comment 12 2018-03-12 18:38:40 PDT

Comment on attachment 335666 [details] Patch Clearing flags on attachment: 335666 Committed r229567: <https://trac.webkit.org/changeset/229567>

WebKit Commit Bot

Comment 13 2018-03-12 18:38:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.