Bug 183409

Summary: webkitpy: --dedicated-simulators does not boot the correct number of simulators
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, ddkilzer, ews-watchlist, glenn, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future none

Jonathan Bedard
Reported 2018-03-07 09:35:36 PST
When --dedicated-simulators is used, we incorrectly use the number of booted simulators as the number of processes to use.
Attachments
Patch (1.57 KB, patch)
2018-03-07 09:39 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews206 for win-future (12.01 MB, application/zip)
2018-03-07 11:32 PST, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-07 09:35:58 PST
<rdar://problem/38224631>
Jonathan Bedard
Comment 2 2018-03-07 09:39:22 PST
Created attachment 335197 [details] Patch
EWS Watchlist
Comment 3 2018-03-07 11:32:40 PST
Comment on attachment 335197 [details] Patch Attachment 335197 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/6841440 New failing tests: http/wpt/resource-timing/rt-initiatorType-media.html
EWS Watchlist
Comment 4 2018-03-07 11:32:50 PST
Created attachment 335202 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Jonathan Bedard
Comment 5 2018-03-07 11:39:14 PST
This patch definitely didn't cause a windows EWS failure.
Aakash Jain
Comment 6 2018-03-07 15:32:41 PST
Comment on attachment 335197 [details] Patch Looks good.
WebKit Commit Bot
Comment 7 2018-03-07 16:07:31 PST
Comment on attachment 335197 [details] Patch Clearing flags on attachment: 335197 Committed r229379: <https://trac.webkit.org/changeset/229379>
WebKit Commit Bot
Comment 8 2018-03-07 16:07:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.