Bug 183404

Summary:

[GTK][WPE] Leak checker is not working in WebKitGLib web process tests

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, ews-watchlist, gustavo, lforschler, mcatanzaro, webkit-bug-importer

Priority:

Keywords:

Gtk, InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mcatanzaro: review+

Description Carlos Garcia Campos 2018-03-07 04:20:48 PST

This might have regressed when we started to use the JSC garbage collector timers. The thing is that we expect that the WebProcessTester object that we expose to JavaScript is released when the web frame is destroyed, but that's no longer the case. On window object cleared a GC is scheduled, but JSC timers do the actual garbage collection later. In the case of tests that never happens because the web process finishes quickly after the test. We need to force a garbage collection at some point when the web page is destroyed.

Comment 1 Carlos Garcia Campos 2018-03-07 04:34:52 PST

Created attachment 335184 [details]
Patch

Comment 2 EWS Watchlist 2018-03-07 04:36:36 PST

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Carlos Garcia Campos 2018-03-07 22:34:48 PST

Committed r229395: <https://trac.webkit.org/changeset/229395>

Comment 4 Radar WebKit Bug Importer 2018-03-07 22:35:46 PST

<rdar://problem/38250675>