Bug 183399

Summary: Simplify the variants of FunctionPtr constructors.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, fpizlo, jfbastien, keith_miller, msaboff, rmorisset, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+, commit-queue: commit-queue-

Mark Lam
Reported 2018-03-07 00:44:37 PST
We should able to use a templatized constructor instead of explicitly declaring variants based on function prototypes.
Attachments
proposed patch. (6.88 KB, patch)
2018-03-07 00:58 PST, Mark Lam 		ysuzuki: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-03-07 00:45:05 PST
<rdar://problem/38212980>
Mark Lam
Comment 2 2018-03-07 00:58:23 PST
Created attachment 335177 [details] proposed patch.
Yusuke Suzuki
Comment 3 2018-03-07 08:03:03 PST
Comment on attachment 335177 [details] proposed patch. Nice, r=me.
Mark Lam
Comment 4 2018-03-07 09:43:12 PST
Comment on attachment 335177 [details] proposed patch. Thanks for the review. Let's land this.
WebKit Commit Bot
Comment 5 2018-03-07 10:21:45 PST
Comment on attachment 335177 [details] proposed patch. Rejecting attachment 335177 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 335177, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: st, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. error: The last gc run reported the following. Please correct the root cause and remove /Volumes/Data/EWS/WebKit/.git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. Full output: http://webkit-queues.webkit.org/results/6841108
Mark Lam
Comment 6 2018-03-07 10:27:57 PST
Landed in r229367: <https://trac.webkit.org/r229367>.
Note You need to log in before you can comment on or make changes to this bug.