Bug 183383 – webkitfullscreenchange event not fired at the same time as :-webkit-full-screen pseudo selector changes; causes glitchiness

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

webkitfullscreenchange event not fired at the same time as :-webkit-full-screen pseudo selector changes; causes glitchiness

[Jer Noble]

Created attachment 335137 [details]
Patch

[EWS Watchlist]

Comment on attachment 335137 [details]
Patch

Attachment 335137 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6831766

New failing tests:
media/fullscreen-video-going-into-pip.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/video-webkit-playsinline.html
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html
media/video-playsinline.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html
media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html

[EWS Watchlist]

Created attachment 335145 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Radar WebKit Bug Importer]

<rdar://problem/38197028>

[EWS Watchlist]

Comment on attachment 335137 [details]
Patch

Attachment 335137 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6831820

New failing tests:
media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html
media/video-playsinline.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html
media/video-webkit-playsinline.html

[EWS Watchlist]

Created attachment 335146 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335137 [details]
Patch

Attachment 335137 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6831684

New failing tests:
media/modern-media-controls/media-controller/media-controller-fullscreen-change.html
media/modern-media-controls/start-support/start-support-fullscreen.html
media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html
media/video-playsinline.html
media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html
media/video-webkit-playsinline.html

[EWS Watchlist]

Created attachment 335148 [details]
Archive of layout-test-results from ews112 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Jer Noble]

Created attachment 335377 [details]
Patch

[EWS Watchlist]

Comment on attachment 335377 [details]
Patch

Attachment 335377 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6868193

New failing tests:
media/media-fullscreen-return-to-inline.html
media/media-fullscreen-pause-inline.html

[EWS Watchlist]

Created attachment 335384 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335377 [details]
Patch

Attachment 335377 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6868321

New failing tests:
media/media-fullscreen-return-to-inline.html
media/media-fullscreen-pause-inline.html
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

[EWS Watchlist]

Created attachment 335385 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 335377 [details]
Patch

Attachment 335377 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/6868323

New failing tests:
media/media-fullscreen-pause-inline.html

[EWS Watchlist]

Created attachment 335386 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Jer Noble]

Created attachment 335393 [details]
Patch

[EWS Watchlist]

Comment on attachment 335393 [details]
Patch

Attachment 335393 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/6871492

New failing tests:
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

[EWS Watchlist]

Created attachment 335403 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Jer Noble]

Created attachment 335405 [details]
Patch

[Eric Carlson]

Comment on attachment 335405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335405&action=review

> Source/WebCore/ChangeLog:20
> +        A number of layout tests depend on the behavior that the element will be in fullscreen when the 'playing' event
> +        fires. This was true for DRT (but not WKTR), since its fullscreen implementations were deliberately synchronous, but
> +        won't necessarily be true for all ports. Fix this in a subsequent patch.

You should note webkit.org/b/183490 here.

[WebKit Commit Bot]

Comment on attachment 335405 [details]
Patch

Clearing flags on attachment: 335405

Committed r229466: <https://trac.webkit.org/changeset/229466>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change caused API test Fullscreen.TopContentInset to time out:
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/3882

[Jer Noble]

(In reply to Ryan Haddad from comment #23)
> This change caused API test Fullscreen.TopContentInset to time out:
> https://build.webkit.org/builders/
> Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/3882

I'll look into this.

[Jer Noble]

Reopening to attach new patch.

[Jer Noble]

Created attachment 335456 [details]
Follow-up patch

[WebKit Commit Bot]

Comment on attachment 335456 [details]
Follow-up patch

Clearing flags on attachment: 335456

Committed r229487: <https://trac.webkit.org/changeset/229487>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

Regression: bug #183611