Bug 183374

Summary:

LayoutTests/http/tests/misc/window-dot-stop.html fails with async policy delegate

Product:

WebKit

Reporter:

Danyao Wang <danyao>

Component:

Page Loading

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

beidson, cdumez

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

180568

Attachments:

Description	Flags
Patch	none
Fixed typo. Patch for review	cdumez: review-

Description Danyao Wang 2018-03-06 09:41:53 PST

This test now fails because with async decide policy, the iframe navigation is canceled before it gets to willSendRequest stage. window.stop is still working as intended.

Comment 1 Danyao Wang 2018-03-06 10:29:00 PST

Created attachment 335112 [details]
Patch

Comment 2 Danyao Wang 2018-03-06 10:33:15 PST

Created attachment 335113 [details]
Fixed typo. Patch for review

Comment 3 Chris Dumez 2018-03-06 10:43:31 PST

Comment on attachment 335113 [details]
Fixed typo. Patch for review

You would also need to fix the existing test. Otherwise, this does not help us enable async delegates by default. In this case though, since there is no code change, I am not convinced it is worth landing any new test. We can merely rebaseline LayoutTests/http/tests/misc/window-dot-stop.html when we enable async delegates by default.

Comment 4 Danyao Wang 2018-03-06 11:24:32 PST

OK that sounds reasonable. I think the failure message I added to the onload events make the test slightly more clear, but this seems minor and I'm OK just rebaseline later.