Bug 183354

Summary: Ensure system appearance is default for web content
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch thorton: review+

Megan Gardner
Reported 2018-03-05 17:49:10 PST
Ensure system appearance is default for web content
Attachments
Patch (12.94 KB, patch)
2018-03-05 17:52 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (8.45 KB, patch)
2018-03-05 18:03 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (12.94 KB, patch)
2018-03-06 10:13 PST, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (12.95 KB, patch)
2018-03-06 11:12 PST, Megan Gardner 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2018-03-05 17:52:29 PST
Created attachment 335061 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-03-05 17:53:46 PST
<rdar://problem/38162381>
Megan Gardner
Comment 3 2018-03-05 18:03:51 PST
Created attachment 335062 [details] Patch
Tim Horton
Comment 4 2018-03-05 21:49:45 PST
The new files are missing from your patch.
Megan Gardner
Comment 5 2018-03-06 10:13:08 PST
Created attachment 335111 [details] Patch
Tim Horton
Comment 6 2018-03-06 10:19:23 PST
Comment on attachment 335111 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335111&action=review Please make sure EWS is green before landing. > Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h:44 > + NSAppearance* m_savedSystemAppearance; Star's on the wrong side. > Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm:37 > + m_savedSystemAppearance = [[NSAppearance currentAppearance] retain]; Why is m_savedSystemAppearance not a retainptr?
Megan Gardner
Comment 7 2018-03-06 11:12:53 PST
Created attachment 335117 [details] Patch
Tim Horton
Comment 8 2018-03-06 11:27:02 PST
Comment on attachment 335117 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=335117&action=review > Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm:38 > + NSAppearance* newAppearance = [NSAppearance appearanceNamed:NSAppearanceNameAqua]; Stars on the wrong side :)
Megan Gardner
Comment 9 2018-03-06 12:22:14 PST
https://trac.webkit.org/r229336
Note You need to log in before you can comment on or make changes to this bug.