Bug 183312

Summary: [WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, jfbastien, mark.lam, saam, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
mark.lam: review+
Patch none

Yusuke Suzuki
Reported 2018-03-03 06:23:40 PST
[WTF] Move currentCPUTime and sleep(Seconds) to CPUTime.h and Seconds.h respectively
Attachments
Patch (120.07 KB, patch)
2018-03-03 06:29 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (120.40 KB, patch)
2018-03-03 07:21 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (120.47 KB, patch)
2018-03-03 09:22 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (120.53 KB, patch)
2018-03-04 00:00 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch (120.50 KB, patch)
2018-03-04 17:52 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-03-03 06:29:38 PST
Created attachment 334954 [details] Patch
Yusuke Suzuki
Comment 2 2018-03-03 07:21:50 PST
Created attachment 334956 [details] Patch
Yusuke Suzuki
Comment 3 2018-03-03 09:22:32 PST
Created attachment 334960 [details] Patch
Yusuke Suzuki
Comment 4 2018-03-04 00:00:45 PST
Created attachment 334976 [details] Patch
Mark Lam
Comment 5 2018-03-04 09:44:34 PST
Comment on attachment 334976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334976&action=review r=me > Source/WTF/ChangeLog:16 > + conslidate various time-source implementations in one place. *consolidate*
Yusuke Suzuki
Comment 6 2018-03-04 11:05:10 PST
Comment on attachment 334976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334976&action=review >> Source/WTF/ChangeLog:16 >> + conslidate various time-source implementations in one place. > > *consolidate* Thanks, fixed.
Yusuke Suzuki
Comment 7 2018-03-04 17:52:52 PST
Created attachment 334985 [details] Patch
Yusuke Suzuki
Comment 8 2018-03-04 17:53:30 PST
Comment on attachment 334985 [details] Patch Let's go.
WebKit Commit Bot
Comment 9 2018-03-04 18:34:02 PST
Comment on attachment 334985 [details] Patch Clearing flags on attachment: 334985 Committed r229209: <https://trac.webkit.org/changeset/229209>
JF Bastien
Comment 10 2018-03-05 09:48:10 PST
Comment on attachment 334985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334985&action=review > Source/WTF/wtf/cocoa/CPUTimeCocoa.mm:79 > + thread_info(threadPort, THREAD_BASIC_INFO, reinterpret_cast<thread_info_t>(&info), &infoCount); RELEASE_ASSERT that it returns KERN_SUCCESS. > Source/WTF/wtf/unix/CPUTimeUnix.cpp:50 > + clock_gettime(CLOCK_THREAD_CPUTIME_ID, &ts); Release assert that it returns 0. > Source/WTF/wtf/win/CPUTimeWin.cpp:68 > + ASSERT_UNUSED(ret, ret); Release assert that it's non-zero.
Yusuke Suzuki
Comment 11 2018-03-05 10:56:05 PST
Comment on attachment 334985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334985&action=review Thank you! >> Source/WTF/wtf/cocoa/CPUTimeCocoa.mm:79 >> + thread_info(threadPort, THREAD_BASIC_INFO, reinterpret_cast<thread_info_t>(&info), &infoCount); > > RELEASE_ASSERT that it returns KERN_SUCCESS. Nice, I'll fix in a follow-up patch. >> Source/WTF/wtf/unix/CPUTimeUnix.cpp:50 >> + clock_gettime(CLOCK_THREAD_CPUTIME_ID, &ts); > > Release assert that it returns 0. Nice, fixed. >> Source/WTF/wtf/win/CPUTimeWin.cpp:68 >> + ASSERT_UNUSED(ret, ret); > > Release assert that it's non-zero. Fixed.
Yusuke Suzuki
Comment 12 2018-03-05 11:04:05 PST
Committed r229289: <https://trac.webkit.org/changeset/229289>
Radar WebKit Bug Importer
Comment 13 2018-03-05 11:06:36 PST
<rdar://problem/38146407>
Yusuke Suzuki
Comment 14 2018-03-12 20:10:49 PDT
Committed r229571: <https://trac.webkit.org/changeset/229571>
Note You need to log in before you can comment on or make changes to this bug.