Summary: | didReceiveServerRedirectForProvisionalNavigation is not called in case of document redirection with service worker registration change | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, achristensen, ap, cdumez, commit-queue, dbates, ews-watchlist, japhet, jbedard, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
youenn fablet
2018-03-02 12:17:30 PST
Created attachment 334916 [details]
Patch
Comment on attachment 334916 [details] Patch Rejecting attachment 334916 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334916, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: st, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. error: The last gc run reported the following. Please correct the root cause and remove /Volumes/Data/EWS/WebKit/.git/gc.log. Automatic cleanup will not be performed until the file is removed. warning: There are too many unreachable loose objects; run 'git prune' to remove them. Full output: http://webkit-queues.webkit.org/results/6833744 Apparently, it did go through EWS, not sure what is happening there. EWS seems to have landed it as https://trac.webkit.org/r229349 despite the error message > Apparently, it did go through EWS, not sure what is happening there. I am also not sure what was the issue here. Tracking in https://bugs.webkit.org/show_bug.cgi?id=183392 |