Summary: | [CMake] Split JSC header copying into public and private targets | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||
Component: | Tools / Tests | Assignee: | Don Olmstead <don.olmstead> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, annulen, commit-queue, Hironori.Fujii, lforschler, mcatanzaro, pvollan, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Don Olmstead
2018-03-01 11:37:48 PST
Created attachment 334830 [details]
Patch
Add TARGET_NAME parameter
Please add usage to the patch to demonstrate need of such complications Created attachment 334835 [details]
Patch
This patch splits the copying of headers into 2 separate targets, one for public and one for private.
JavaScriptCore and WebKit have both public and private headers that need to be installed. In this case LLIntOffsets technically needs access to the public headers of JavaScriptCore before it is built. This makes the dependencies more explicit.
Created attachment 334837 [details]
Patch
Rename target in Tools
I don't like this TARGET_NAME idea. How do you think a following style? WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore PUBLIC_HEADERS ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS} PRIVATE_HEADERS ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS} DERIVED_SOURCE_DIRECTORIES ${DERIVED_SOURCES_DIR}/JavaScriptCore ${DERIVED_SOURCES_DIR}/JavaScriptCore/inspector FLATTENED) And, it should be unified into WEBKIT_FRAMEWORK in the future (Bug 182593 Comment 8). (In reply to Fujii Hironori from comment #5) > I don't like this TARGET_NAME idea. > > How do you think a following style? > > WEBKIT_MAKE_FORWARDING_HEADERS(JavaScriptCore > PUBLIC_HEADERS ${JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS} > PRIVATE_HEADERS ${JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS} > DERIVED_SOURCE_DIRECTORIES > ${DERIVED_SOURCES_DIR}/JavaScriptCore > ${DERIVED_SOURCES_DIR}/JavaScriptCore/inspector > FLATTENED) > > And, it should be unified into WEBKIT_FRAMEWORK in the future (Bug 182593 > Comment 8). I was thinking that at a later time the current WEBKIT_MAKE_FORWARDING_HEADERS is turned into a private CMake function that would be invoked either in WEBKIT_FRAMEWORK or in something like what you are suggesting here. Comment on attachment 334837 [details] Patch Rejecting attachment 334837 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 334837, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: rdparty/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://webkit-queues.webkit.org/results/6812439 Committed https://trac.webkit.org/r229282 |