Bug 183249

Summary:

Move resource load statistics tests from js-test-pre.js to js-test.js

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

Tools / Tests

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none

John Wilander

Reported 2018-03-01 10:59:33 PST

A bunch of the resource load statistics tests use js-test-pre.js without a corresponding js-test-post.js or js-test-post-async.js. We should move them to js-test.js. This may address some of the flakiness seen on the bots.

Attachments
Patch (30.10 KB, patch) 2018-03-01 11:11 PST, John Wilander	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.15 MB, application/zip) 2018-03-01 12:41 PST, EWS Watchlist	no flags	Details
Patch (31.55 KB, patch) 2018-03-01 13:16 PST, John Wilander	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-03-01 11:04:38 PST

<rdar://problem/38033096>

Radar WebKit Bug Importer

Comment 2 2018-03-01 11:04:41 PST

<rdar://problem/38033103>

John Wilander

Comment 3 2018-03-01 11:07:57 PST

I will use <rdar://problem/38033096> as the Radar equivalent.

John Wilander

Comment 4 2018-03-01 11:11:18 PST

Created attachment 334827 [details] Patch

EWS Watchlist

Comment 5 2018-03-01 12:41:43 PST

Comment on attachment 334827 [details] Patch Attachment 334827 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/6723378 New failing tests: http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion.html

EWS Watchlist

Comment 6 2018-03-01 12:41:44 PST

Created attachment 334841 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

John Wilander

Comment 7 2018-03-01 13:16:31 PST

Created attachment 334845 [details] Patch

WebKit Commit Bot

Comment 8 2018-03-01 15:22:16 PST

Comment on attachment 334845 [details] Patch Clearing flags on attachment: 334845 Committed r229152: <https://trac.webkit.org/changeset/229152>

WebKit Commit Bot

Comment 9 2018-03-01 15:22:17 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.